Closed Bug 1173758 Opened 9 years ago Closed 9 years ago

[toolkit][ServiceWorkers] SimpleOfflineCache call CacheStorage.open should not be called in every fetch request

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S3 (24Jul)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: arcturus, Assigned: arcturus)

References

Details

Attachments

(1 file)

Pointer to github pull request
60 bytes, text/x-github-pull-request
salva
: review+
Details | Review
Target Milestone: --- → NGA S3 (26Jun)
Blocks: nga-toolkit-service-workers
Whiteboard: [s4]
See Also: → 1172902
Assignee: nobody → francisco
Whiteboard: [s4]
Status: NEW → ASSIGNED
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)
Comment on attachment 8631119 [details] [review] Pointer to github pull request Hi :arcturus, thank you for taking this bug which will increase the performance of the simple offline cacher and remove dependencies with the helper (actually, to be really simple I think it's good to be independent). You have some comments on GitHub mainly related with tests, take a look and ask for my review again when you're done. Thank you very much again and good work!
Attachment #8631119 - Flags: review?(salva)
Target Milestone: FxOS-S2 (10Jul) → FxOS-S3 (24Jul)
Comment on attachment 8631119 [details] [review] Pointer to github pull request Salva, just added your suggestions, could you take another look? Thanks
Attachment #8631119 - Flags: review?(salva)
Comment on attachment 8631119 [details] [review] Pointer to github pull request Second try?
Comment on attachment 8631119 [details] [review] Pointer to github pull request Almost there. Please, see the new comments on GitHub and ask for my review once you're done. Thank you!
Attachment #8631119 - Flags: review?(salva)
Comment on attachment 8631119 [details] [review] Pointer to github pull request Sorry I totally missed your comment in my last pr, now it's include in the last commit. Thanks!
Attachment #8631119 - Flags: review?(salva)
Comment on attachment 8631119 [details] [review] Pointer to github pull request Now it's perfect. Thank you very much.
Attachment #8631119 - Flags: review?(salva) → review+
Landed: https://github.com/gaia-components/serviceworkerware/commit/313c9d5fec64ec1dc016d8ae67d06cc30cda8bd1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: