Closed Bug 1173887 Opened 5 years ago Closed 5 years ago

Only display one title + favicon for the first doorhanger in a popup

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(1 file)

Currently, we display the title + favicon for every doorhanger in a doorhanger popup. It should only be shown for the topmost doorhanger.

For DoorHangerPopup, this means only the first doorhanger should have the title + favicon.

For the SiteIdentityPopup, only the site identity doorhanger have the title + favicon, and no other doorhangers should display that information.
Bug 1173887 - Only display one title + favicon for the first doorhanger in a popup. r=ally
Attachment #8623858 - Flags: review?(ally)
Assignee: nobody → liuche
Depends on: 1150613
Comment on attachment 8623858 [details]
MozReview Request: Bug 1173887 - Only display one title + favicon for the first doorhanger in a popup. r=ally

https://reviewboard.mozilla.org/r/11603/#review10233

Good job with the refactoring bit. The logins code as a whole is looking much saner.

::: mobile/android/base/DoorHangerPopup.java:291
(Diff revision 1)
>   

can we get rid of this whitespace while we're here?
Attachment #8623858 - Flags: review?(ally) → review+
https://hg.mozilla.org/mozilla-central/rev/2137ce8f916f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Depends on: 1400544
You need to log in before you can comment on or make changes to this bug.