App-disabled add-ons can be enabled through the add-on manager context menu

RESOLVED FIXED in Firefox 41

Status

()

Firefox for Android
Add-on Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

35 Branch
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Add-ons can be disabled by Firefox if they're blocklisted (or unsigned, when we start requiring add-on signing), but we don't disable the "enable" context menu item for these force-disabled add-ons.

I would hope that this is just a UI bug that makes it look like the user actually enables these add-ons, but we should look into whether or not that enable functionality actually works. If it does, we should probably uplift a patch for this.
(Assignee)

Comment 1

3 years ago
Created attachment 8621336 [details]
MozReview Request: Bug 1173895 - Hide enable/disable context menu items for app disabled add-ons. r=liuche

Bug 1173895 - Hide enable/disable context menu items for app disabled add-ons. r=liuche
Attachment #8621336 - Flags: review?(liuche)
(Assignee)

Comment 2

3 years ago
(In reply to :Margaret Leibovic from comment #0)

> I would hope that this is just a UI bug that makes it look like the user
> actually enables these add-ons, but we should look into whether or not that
> enable functionality actually works. If it does, we should probably uplift a
> patch for this.

I verified that this isn't a security problem. Selecting "Enable" just makes the add-on look enabled, but doesn't change anything under the hood.
(Assignee)

Updated

3 years ago
Summary: App disable add-ons can be enabled through the add-on manager context menu → App-disabled add-ons can be enabled through the add-on manager context menu
Comment on attachment 8621336 [details]
MozReview Request: Bug 1173895 - Hide enable/disable context menu items for app disabled add-ons. r=liuche

https://reviewboard.mozilla.org/r/10961/#review9575

Ship It!

::: mobile/android/chrome/content/aboutAddons.js:63
(Diff revision 1)
> +    if (addon.appDisabled) {

If we allow addons to be re-enabled, you should include a way to re-enable these addons if the addon.appDisabled flag becomes false (or if it doesn't exist anymore, whatever that method is).
Attachment #8621336 - Flags: review?(liuche) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Chenxia Liu [:liuche] from comment #3)
> Comment on attachment 8621336 [details]
> MozReview Request: Bug 1173895 - Hide enable/disable context menu items for
> app disabled add-ons. r=liuche
> 
> https://reviewboard.mozilla.org/r/10961/#review9575
> 
> Ship It!
> 
> ::: mobile/android/chrome/content/aboutAddons.js:63
> (Diff revision 1)
> > +    if (addon.appDisabled) {
> 
> If we allow addons to be re-enabled, you should include a way to re-enable
> these addons if the addon.appDisabled flag becomes false (or if it doesn't
> exist anymore, whatever that method is).

Yeah, currently we don't have any listeners in place to update the add-ons if their appDisabled state changes (more likely than not, add-ons would go from being enabled to disabled, since I don't see how we would decide to change our mind about an insecure add-on suddenly being secure). I'm going to be doing more work to deal with the UI for these disabled add-ons in bug 1170841.
https://hg.mozilla.org/mozilla-central/rev/59d7a4a0bd32
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.