Closed Bug 1173971 Opened 4 years ago Closed 4 years ago

Consider setting GDK_CORE_DEVICE_EVENTS on test infrastructure for GTK3

Categories

(Core :: Widget: Gtk, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: acomminos, Assigned: acomminos)

References

Details

Attachments

(1 file)

The focus issues with XInput2 and GTK3 detailed in bug 1170342 cause hangs with automated testing; for now, it may be best to force legacy Xlib events on the test infrastructure and make a plan to remove it in the future.
I think it makes sense to do this temporarily to improve our test coverage.
This patch sets GDK_CORE_DEVICE_EVENTS for all mochitests on GTK3. It results in a notable improvement of bustage on try (https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a31afa27686, a few other patches included).
Attachment #8621589 - Flags: review?(karlt)
Attachment #8621589 - Flags: review?(karlt) → review+
Whoops, that was a GTK2 try push.

Actual GTK3 push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffaf884b9c8c
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d16d6da34d3c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: 1170342
You need to log in before you can comment on or make changes to this bug.