1174043 - WebGLContextLossHandler::DisableTimer should run if timer is not yet disabled

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Run-DisableTimer-if-timer-is-not-yet-disabled.patch

Right now, the early-out conditional is wrong.

This has been hoisted from bug 709490.

This is from:
http://hg.mozilla.org/mozilla-central/rev/34de348f9529

Comment 1

[Kelsey Gilbert [:jgilbert]]

Running Try on this:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=069f36041831

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f6b09143c8b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/20cf73b4c8f5 for dt2 failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=10741186&repo=mozilla-inbound

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Run DisableTimer if timer is not yet disabled.

We didn't reset mIsTimerRunning when timer is disabled so we hit the test failure. So I reset mIsTimerRunning to fix it.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=746ecb1254fe

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fdc2b045984

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5fdc2b045984