Closed Bug 1174055 Opened 5 years ago Closed 5 years ago

Remove WMFReader

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We no longer use WMFReader, so we should remove it. Also, we're loading DLLs it requires (mfreadwrite.dll, propsys.dll) which needlessly does I/O, which I'm getting pinged for in bug 1164925.
Do the loading of WMF DLLs in MFStartup(). Don't bother tracking how many times we've loaded them, and don't bother unloading them when we're done. We trade off memory over speed, and leave them loaded so next time they're needed, they're still loaded.
Attachment #8621414 - Flags: review?(jyavenard)
Long live MediaFormatReader!
Attachment #8621416 - Flags: review?(jyavenard)
Remove some auxiliary functions not removed in the previous patch that are now unused.
Attachment #8621418 - Flags: review?(jyavenard)
Attachment #8621414 - Flags: review?(jyavenard) → review+
Comment on attachment 8621416 [details] [diff] [review]
Patch 1: Remove WMFReader

Review of attachment 8621416 [details] [diff] [review]:
-----------------------------------------------------------------

that's lots of code !
Attachment #8621416 - Flags: review?(jyavenard) → review+
Attachment #8621418 - Flags: review?(jyavenard) → review+
Depends on: 1307223
You need to log in before you can comment on or make changes to this bug.