1174055 - Remove WMFReader

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We no longer use WMFReader, so we should remove it. Also, we're loading DLLs it requires (mfreadwrite.dll, propsys.dll) which needlessly does I/O, which I'm getting pinged for in bug 1164925.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1c9445b2ba7

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 0: Move WMF DLL loading into MFStartup

Do the loading of WMF DLLs in MFStartup(). Don't bother tracking how many times we've loaded them, and don't bother unloading them when we're done. We trade off memory over speed, and leave them loaded so next time they're needed, they're still loaded.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 1: Remove WMFReader

Long live MediaFormatReader!

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch 2: Remove some other uncalled WMF functions

Remove some auxiliary functions not removed in the previous patch that are now unused.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8621416 [details] [diff] [review]
Patch 1: Remove WMFReader

Review of attachment 8621416 [details] [diff] [review]:
-----------------------------------------------------------------

that's lots of code !

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd221759e418
https://hg.mozilla.org/integration/mozilla-inbound/rev/52813555f500
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fc0cc353d24

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd221759e418
https://hg.mozilla.org/mozilla-central/rev/52813555f500
https://hg.mozilla.org/mozilla-central/rev/6fc0cc353d24