1174062 - Use click() for attachButton too

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1171387 +++

This is somewhat like bug 1171387. I took a long detour on narrowing down the cause because of the behavior I saw in bug 1162360 comment 61.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/30559

Oleg, could you review this please? This should be the last thing blocking bug 1162360 if there is nothing dramatic.

Comment 2

[Oleg Zasypkin [:azasypkin]]

Hey Tim, fix looks good to me, I just left tiny proposition at Github that reduce the risk for "tap vs click vs keyboard" issue bite us in other places.

What do you think?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8621440 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/30559

Patch updated accordingly.

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8621440 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/30559

r+ with small nit in attachment_tests we discussed on IRC and green Treeherder :)

Thanks!

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/45e5ad86657f993147c57eab8cd2e7a1e8c85669

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8d83ea42da447a50094c5ba7e52d351ab078eb7f

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Pushed a follow-up to fix a jshint error:

https://github.com/mozilla-b2g/gaia/commit/e7cde916d02a3bc0c63860e686889a588495db83

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is no longer a valid bug with bug 1176926 in place.

master revert: https://github.com/mozilla-b2g/gaia/commit/5a39ff43424e92e73c468b8f00a6c62476f30177