1174078 - Calling "fetch" inside Service Worker's "onfetch" handler in b2g causes "onfetch" again that leads to an infinite loop

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Oleg Zasypkin [:azasypkin]]

STR:

1. Install [1] as preinstalled app (to workaround bug 1173539);
2. Run it and make sure that service worker is registered;
3. Kill app with Task Manager and run again;
4. Observe log - there is infinite loop that infinitely requests first resource in the app index.html - app.css. 

Flame PVT mc Engineering Build:

Build Identifier: 20150611010205
Git Commit Info: 2015-06-11 18:43:32, 4219419a

[1] https://github.com/azasypkin/sw-tests/tree/master/fxos-app

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Is this an issue with intercepting the app: protocol?

Comment 2

[Oleg Zasypkin [:azasypkin]]

(In reply to Ben Kelly [:bkelly] from comment #1)
> Is this an issue with intercepting the app: protocol?

I was able to reproduce it only with app:// protocol on b2g. I tried to run app in b2g browser [1], but service worker registration was always failing for me at that time, so I just gave up.

[1] http://azasypkin.github.io/sw-tests/fxos-app/

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

I'll be adding a new test on another patch

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Ben Kelly [:bkelly] from comment #1)
> Is this an issue with intercepting the app: protocol?

Yes, this is only happening with the app:// protocol.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Test

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8622374 [details] [diff] [review]
v1

Review of attachment 8622374 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/app/AppProtocolHandler.cpp
@@ +297,5 @@
>  }
>  
> +NS_IMETHODIMP DummyChannel::ForceNoIntercept()
> +{
> +  return NS_OK;

return NS_ERROR_NOT_IMPLEMENTED?

Comment 7

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8622404 [details] [diff] [review]
Test

Review of attachment 8622404 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to see the new patch.

::: dom/workers/test/serviceworkers/app-protocol/sw.js
@@ +22,5 @@
> +    var results = regex.exec(event.request.url);
> +    return results === null ?
> +                       ''   :
> +                       decodeURIComponent(results[1].replace(/\+/g, ' '));
> +  }

Please use the URL and URLSearchParams interfaces instead of manual regexp parsing.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Test

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8622953 [details] [diff] [review]
Test

Review of attachment 8622953 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/app-protocol/sw.js
@@ +16,5 @@
>  });
>  
>  self.addEventListener('fetch', (event) => {
>    if (event.request.url.indexOf('foo.txt') >= 0) {
> +    var searchParams = new URLSearchParams(event.request.url.split("?")[1]);

var searchParams = new URLSearchParams(new URL(event.request.url));

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8d2c117e4b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ea2dfc3325d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8d2c117e4b1
https://hg.mozilla.org/mozilla-central/rev/9ea2dfc3325d

Comment 12

[Noemí Freire (:noemi)]

checked in today's m-c build (6/18) with Flame device and it works as expected. Thanks for fixing it so quickly!

Comment 13

[Maria Angeles Oteo (:oteo)]

As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed