Closed Bug 1174095 Opened 8 years ago Closed 6 years ago

Do not add 'postData' to requests in HAR if there isn't any posted data

Categories

(DevTools :: Netmonitor, defect, P4)

Product:
DevTools
Component:
Netmonitor
Version:
54 Branch
Type:
defect

Tracking

(firefox41 affected, firefox54 affected, firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox41 --- affected
firefox54 --- affected
firefox57 --- fixed

People

(Reporter: sebo, Assigned: dex, Mentored)

References

(
URL
)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data
59 bytes, text/x-review-board-request
Honza
: review+
Details 
If a network request does not contain any posted data, the 'postData' field should be omitted.

Sebastian
I assume that's easy to fix, so adding the 'good-first-bug' keyword.

Sebastian
status-firefox54: --- → affected
Keywords: good-first-bug
Version: Trunk → 54 Branch
Mentor: odvarko
Priority: -- → P4
Hi, I would like to work on this bug, can you assign it to me ? Thanks
(In reply to Xavier ALT [:dex] from comment #2)
> Hi, I would like to work on this bug, can you assign it to me ? Thanks

Done so. Thank you for working on this!

Sebastian
Assignee: nobody → dex
Status: NEW → ASSIGNED
Comment on attachment 8899000 [details]
Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data

https://reviewboard.mozilla.org/r/170338/#review177402

Thanks for working on this, looks reasonable to me!

R+ assuming Try is green.

Honza
Attachment #8899000 - Flags: review?(odvarko) → review+
Comment on attachment 8899000 [details]
Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data

https://reviewboard.mozilla.org/r/170338/#review177506

::: devtools/client/netmonitor/src/har/test/html_har_post-data-test-page.html:19
(Diff revision 1)
>  
>    <body>
>      <p>HAR POST data test</p>
>  
>      <script type="text/javascript">
>        /* exported executeTest, executeTest2 */

It seems I forgot to mark "executeTest3" as exported, explaining the eslint test failure.

I'll update the code/review when I reach home.
Hi Honza, I've update the patch/review, could you give it another "try" ? Thanks
Comment on attachment 8899000 [details]
Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data

https://reviewboard.mozilla.org/r/170338/#review177896

LGTM, thanks!

(btw. you don't have to ask for a review if it's already R+)

Honzz
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72adcbfccfbe
Do not add 'postData' to HAR requests if there isn't any posted data r=Honza
https://hg.mozilla.org/mozilla-central/rev/72adcbfccfbe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.