Do not add 'postData' to requests in HAR if there isn't any posted data

RESOLVED FIXED in Firefox 57

Status

P4
minor
RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: sebo, Assigned: dex, Mentored)

Tracking

({good-first-bug})

54 Branch
Firefox 57
good-first-bug

Firefox Tracking Flags

(firefox41 affected, firefox54 affected, firefox57 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
If a network request does not contain any posted data, the 'postData' field should be omitted.

Sebastian
(Reporter)

Comment 1

a year ago
I assume that's easy to fix, so adding the 'good-first-bug' keyword.

Sebastian
status-firefox54: --- → affected
Keywords: good-first-bug
Version: Trunk → 54 Branch
Mentor: odvarko
Priority: -- → P4
(Assignee)

Comment 2

a year ago
Hi, I would like to work on this bug, can you assign it to me ? Thanks
(Reporter)

Comment 3

a year ago
(In reply to Xavier ALT [:dex] from comment #2)
> Hi, I would like to work on this bug, can you assign it to me ? Thanks

Done so. Thank you for working on this!

Sebastian
Assignee: nobody → dex
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment on attachment 8899000 [details]
Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data

https://reviewboard.mozilla.org/r/170338/#review177402

Thanks for working on this, looks reasonable to me!

R+ assuming Try is green.

Honza
Attachment #8899000 - Flags: review?(odvarko) → review+
(Assignee)

Comment 6

a year ago
mozreview-review
Comment on attachment 8899000 [details]
Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data

https://reviewboard.mozilla.org/r/170338/#review177506

::: devtools/client/netmonitor/src/har/test/html_har_post-data-test-page.html:19
(Diff revision 1)
>  
>    <body>
>      <p>HAR POST data test</p>
>  
>      <script type="text/javascript">
>        /* exported executeTest, executeTest2 */

It seems I forgot to mark "executeTest3" as exported, explaining the eslint test failure.

I'll update the code/review when I reach home.
Comment hidden (mozreview-request)
(Assignee)

Comment 8

a year ago
Hi Honza, I've update the patch/review, could you give it another "try" ? Thanks
Comment on attachment 8899000 [details]
Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data

https://reviewboard.mozilla.org/r/170338/#review177896

LGTM, thanks!

(btw. you don't have to ask for a review if it's already R+)

Honzz

Comment 11

a year ago
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72adcbfccfbe
Do not add 'postData' to HAR requests if there isn't any posted data r=Honza

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/72adcbfccfbe
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.