Closed
Bug 1174095
Opened 8 years ago
Closed 6 years ago
Do not add 'postData' to requests in HAR if there isn't any posted data
Categories
(DevTools :: Netmonitor, defect, P4)
Tracking
(firefox41 affected, firefox54 affected, firefox57 fixed)
RESOLVED
FIXED
Firefox 57
People
(Reporter: sebo, Assigned: dex, Mentored)
References
()
Details
(Keywords: good-first-bug)
Attachments
(1 file)
If a network request does not contain any posted data, the 'postData' field should be omitted. Sebastian
Reporter | ||
Comment 1•6 years ago
|
||
I assume that's easy to fix, so adding the 'good-first-bug' keyword. Sebastian
Updated•6 years ago
|
Mentor: odvarko
Priority: -- → P4
Assignee | ||
Comment 2•6 years ago
|
||
Hi, I would like to work on this bug, can you assign it to me ? Thanks
Reporter | ||
Comment 3•6 years ago
|
||
(In reply to Xavier ALT [:dex] from comment #2) > Hi, I would like to work on this bug, can you assign it to me ? Thanks Done so. Thank you for working on this! Sebastian
Assignee: nobody → dex
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8899000 [details] Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data https://reviewboard.mozilla.org/r/170338/#review177402 Thanks for working on this, looks reasonable to me! R+ assuming Try is green. Honza
Attachment #8899000 -
Flags: review?(odvarko) → review+
Assignee | ||
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8899000 [details] Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data https://reviewboard.mozilla.org/r/170338/#review177506 ::: devtools/client/netmonitor/src/har/test/html_har_post-data-test-page.html:19 (Diff revision 1) > > <body> > <p>HAR POST data test</p> > > <script type="text/javascript"> > /* exported executeTest, executeTest2 */ It seems I forgot to mark "executeTest3" as exported, explaining the eslint test failure. I'll update the code/review when I reach home.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•6 years ago
|
||
Hi Honza, I've update the patch/review, could you give it another "try" ? Thanks
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8899000 [details] Bug 1174095 - Do not add 'postData' to HAR requests if there isn't any posted data https://reviewboard.mozilla.org/r/170338/#review177896 LGTM, thanks! (btw. you don't have to ask for a review if it's already R+) Honzz
Comment 10•6 years ago
|
||
Let's see if the try is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=968d0a5c6f9b0da5468aa6884a8b46fd32852bcb Honza
Comment 11•6 years ago
|
||
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72adcbfccfbe Do not add 'postData' to HAR requests if there isn't any posted data r=Honza
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/72adcbfccfbe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•