1174103 - [gui] put the code for the log view/log model in a new "log.py" file using promoted widgets

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

The log view will probably add quite some code once we will add filters, coloring, etc.

It would be nice to have this code in a specific file, say mozlog/log.py. The idea is to use a promoted widget from the designer, to move around all the code related to the logging fron main.py to log.py.

There is already some promoted widgets in the current code that can help to get started, for example the build_info_browser object in the mainwindow.ui file.

Also, some resources that can help:

http://doc.qt.io/qt-4.8/designer-using-custom-widgets.html#promoting-widgets
http://stackoverflow.com/questions/19622014/how-to-use-promote-to-in-qt-designer-in-pyqt4

Comment 1

[Julien Pagès (:parkouss)]

Hey MikeLing, would you be interested to look into that ? I think it is good to learn more what can be done with the Qt designer (here promote a widget, so you can use the designer to design, and at the same time write custom code that will be used at run time).

Comment 2

[MikeLing]

Sure! I'm interesting in this bug and I would like to start my work after color and filter been implemented :)

Comment 3

[MikeLing]

After talk with Julien on irc, we think he is better choice to work on this bug than I. So, please feel free to take it :)

Thank you for your help

Comment 4

[Julien Pagès (:parkouss)]

Let's do that!

Comment 5

[Julien Pagès (:parkouss)]

Ok, I named the new file log_report.py in fact. I did not asked a review so MikeLing can go on with other cool stuff on the log reporter!

Merged in https://github.com/mozilla/mozregression/commit/7f769bceba8ed71204ea7ae24208baa195daad9d.