Closed
Bug 1174212
Opened 11 years ago
Closed 11 years ago
Skip pointerlock tests on GTK3
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: acomminos, Assigned: acomminos)
References
Details
Attachments
(1 file, 1 obsolete file)
|
859 bytes,
patch
|
acomminos
:
review+
|
Details | Diff | Splinter Review |
Currently we skip pointerlock tests on GTK2 due to intermittent failures detailed in bug 788164- these failures still occur on GTK3 (likely due to async X11 events).
| Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8621672 -
Flags: review?(karlt)
Comment 2•11 years ago
|
||
Comment on attachment 8621672 [details] [diff] [review]
Skip pointerlock tests on GTK3.
>+if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gtk2' and CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gtk3':
I think this can be "if CONFIG['MOZ_WIDGET_TOOLKIT'] not in ('gtk2', 'gtk3'):".
Attachment #8621672 -
Flags: review?(karlt) → review+
| Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8621672 -
Attachment is obsolete: true
Attachment #8622471 -
Flags: review+
| Assignee | ||
Comment 4•11 years ago
|
||
Whoops, that was a GTK2 try push.
Actual GTK3 try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46a362854b18
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•