1174220 - Remove MediaLargeByteBuffer

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Biru [:poiru]]

FallibleTArray will be removed in bug 968520 so MediaLargeByteBuffer needs to go. All MediaLargeByteBuffer calls already include the `mozilla::fallible` parameter so we can safely replace MediaLargeByteBuffer with MediaByteBuffer. In the future, one should use the `mozilla::fallible` parameter where fallibility is wanted.

Comment 1

[Biru [:poiru]]

Attachment: Remove capacity constructor of MediaLargeByteBuffer

Comment 2

[Biru [:poiru]]

Attachment: Part 2: Use MediaByteBuffer instead of MediaLargeByteBuffer

All MediaLargeByteBuffer calls already include the `mozilla::fallible`
parameter so we can safely replace MediaLargeByteBuffer with MediaByteBuffer.
In the future, one should use the `mozilla::fallible` parameter where
fallibility is wanted.

Comment 3

[Biru [:poiru]]

Attachment: Part 3: Remove MediaLargeByteBuffer

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8621680 [details] [diff] [review]
Part 2: Use MediaByteBuffer instead of MediaLargeByteBuffer

Review of attachment 8621680 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/MediaData.h
@@ +21,5 @@
>  class Image;
>  class ImageContainer;
>  }
>  
> +class MediaByteBuffer;

duplicate

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8621681 [details] [diff] [review]
Part 3: Remove MediaLargeByteBuffer

wish all patches were like that: one scope, one patch.. perfect

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8651c422edfb
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbc7259a368
https://hg.mozilla.org/integration/mozilla-inbound/rev/a493653ebbed

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8651c422edfb
https://hg.mozilla.org/mozilla-central/rev/9cbc7259a368
https://hg.mozilla.org/mozilla-central/rev/a493653ebbed