Closed
Bug 1174245
Opened 10 years ago
Closed 10 years ago
Add platform mappings for windows7-64 and osx-10-9
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
Currently we are missing the mapping for the following two platforms:
windows7-64
osx-10-9
https://github.com/mozilla/treeherder/blob/master/ui/js/values.js#L7
As discussed on IRC I'm going to add those now because we can benefit from those for the reporting of the firefox-ui-tests.
|
Assignee | |
Comment 1•10 years ago
|
||
Given that buildbot doesn't support those platforms I only added the changes to the ui part. I hope that this is fine.
Attachment #8621715 -
Flags: review?(cdawson)
|
||
Comment 2•10 years ago
|
||
For what its worth these changes look correct to me, and I ran the PR branch locally pointing to production in the absence of corresponding platform jobs.
|
||
Updated•10 years ago
|
Attachment #8621715 -
Flags: review?(cdawson) → review+
|
||
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b56cdc8768c288c639dd945177bdc2de70e91a4a
Bug 1174245 - Add platform mappings for windows7-64 and osx-10-9. r=camd
https://github.com/mozilla/treeherder/commit/b8c180b3ce1fab4ebc56ebc3cef1ad65378e92e9
Merge pull request #625 from whimboo/platforms
Bug 1174245 - Add platform mappings for windows7-64 and osx-10-9. r=camd
|
|
Assignee | |
Comment 4•10 years ago
|
||
I assume I can close it as fixed. If there is something missing please adjust the flags.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•10 years ago
|
||
Perfect Henrik, thank you!
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
You need to log in
before you can comment on or make changes to this bug.
Description
•