1174420 - SimplePush API broken on B2G

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[:gerard-majax]

On my devices running B2G master, FindMyDevice is never able to find my devices, even though the registration seems to be done. Further debugging in bug 1159046 shows that |navigator.push.register()| never trigger a success or error callback or Promise keep waiting.

So far I could find that PushServiceLauncher.js was never even loaded. Extracting omni.ja there is definition in the manifest for this service to be triggered upon "app-startup" but this seems not to be working.

MOZ_SIMPLEPUSH=1 is present in objdir-gecko/config.status

Extracted omni.ja defines app-startup on PushServiceLauncher:
> gecko/omni $ grep -R 'PushServiceLauncher' 
> components/components.manifest:component {4b8caa3b-3c58-4f3c-a7f5-7bd9cb24c11d} PushServiceLauncher.js
> components/components.manifest:category app-startup PushServiceLauncher service,@mozilla.org/push/ServiceLauncher;1

But I cannot find PushServiceLauncher in omni.ja:
> gecko/omni$ find . | grep PushService
> ./chrome/toolkit/content/global/PushServiceChildPreload.js
> ./modules/PushService.jsm
> gecko/omni$

Comment 1

[:gerard-majax]

Attachment: Package PushService launcher on B2G

Comment 2

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a0baa4ea9a1

Comment 3

[Lina Butler (ex-Mozilla)]

Comment on attachment 8621982 [details] [diff] [review]
Package PushService launcher on B2G

Review of attachment 8621982 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: b2g/installer/package-manifest.in
@@ +648,5 @@
>  @RESPATH@/components/AppsService.manifest
>  @RESPATH@/components/Push.js
>  @RESPATH@/components/Push.manifest
>  @RESPATH@/components/PushNotificationService.js
> +@RESPATH@/components/PushServiceLauncher.js

We'll want to update the component IDs and paths in `Push.manifest`, too, since the old Simple Push and new Web Push APIs currently use the same ones. But let's land this first, and follow up with bug 1159046.

Comment 4

[:gerard-majax]

Attachment: Package PushService launcher on B2G

Just changing the r=, carrying r+

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/2ecd91504475

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2ecd91504475