1174498 - [ISE] When doing a revert

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Jean-Yves Perrier [:teoli]]

What did you do?
================
1. Go to https://developer.mozilla.org/en-US/docs/Web/API/URLUtils/hash$revert/471955
2. Added a comment
3. Click the ok button

What happened?
==============
ISE

What should have happened?
==========================
Revert or explicit error message

Is there anything else we should know?
======================================
There was a "move" between current revision and the one I want to revert to.

(I'm manually reverting now as this is needed)

Comment 1

[Stephanie Hobson [:shobson]]

We reverted a test page without trouble so it is probably in combination with the move that is the problem.

Comment 2

[Jannis Leidel [:jezdez]]

Hm, the error log (https://errormill.mozilla.org/mdn/mdn/group/398408/) indicates a race condition during saving the revision in question, when it tries to make the old revision the current of the revisions's document. This may be a bigger issue with the autocommit behavior or an issue with the MySQL backend. Needs more eyes on this.

Comment 3

[Luke Crouch [:groovecoder]]

Sent https://github.com/mozilla/kuma/pull/3483 - it doesn't prevent this issue, but it brings the proper error message up to the UI. I.e., you need to delete the redirect document before you can do the revert.

Comment 4

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/b32a29f4fc7bf3fff97d56e951c17879e68d9a8b
fix bug 1174498 - error message for revert dupes

When a user reverts a document to an old revision, we want to catch the
IntegrityError if it collides with the document's redirect, so the user knows
they can fix it by deleting the redirect.

https://github.com/mozilla/kuma/commit/1691b674170a8c1e7eb72c5f97e5ef712d1a7fcb
Merge pull request #3483 from mozilla/revert-dupe-ise-1174498

fix bug 1174498 - error message for revert dupes