1174521 - no click is working om autoscout24.de

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[TheRave]

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150613030206

Steps to reproduce:

open Link:

http://fahrzeuge.autoscout24.de/?atype=C&make=9&mmvco=1&model=1624&mmvmk0=9&mmvmd0=1624&fuel=B&pricefrom=1000&priceto=100000&kmto=50000&fregfrom=2013&cy=D&doorfrom=4&doorto=5&ustate=N%2CU&sort=price&eq=39&dtr=s

According Arai from IRC, mozregression tells it's a regression from bug 1143570.
He confirmed that backing out https://hg.mozilla.org/mozilla-central/rev/f6a0792e6259 fixes this.






Actual results:

No link is clickable.


Expected results:

Links should work.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Testcase for unclickable dropdown menu

This seems to be a minimum set.
So, clickable item inside floating box, another box with "position: absolute" style, followed by another (maybe inline) node.
(maybe the bottom-most line of the last element matter?)

If I hover mouse on the text "B", the dropdown menu become clickable.

In the autoscout24.de page, most contents are inside floating boxes, and there are several "position: absolute" boxes, followed by an image element with width="2" and height="2", which is placed around top-right corner of the page.

Comment 3

[Jorg K (CEST = GMT+2)]

I can confirm that on a daily compiled just now the following page
http://fahrzeuge.autoscout24.de/?dtr=s
does not work. The links (Fahrzeugsuche, Werkstattsuche, Verkaufen, etc. ) in the menu don't respond and all the other links on the page don't work either.
Backing out https://hg.mozilla.org/mozilla-central/rev/f6a0792e6259 fixes this.
Sorry, this was hard to believe, so I had to try it myself ;-)

Comment 4

[(no longer active)]

roc, are you OK with a backout of https://hg.mozilla.org/mozilla-central/rev/f6a0792e6259 plus a patch that adds a test for it?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, sure

Comment 6

[(no longer active)]

Attachment: Backout the second part of bug 1143570 to fix the regression

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b857e7a2ab26

Comment 8

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=10871525&repo=mozilla-inbound

Comment 9

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e20e65a1f5e8

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/587e2801a239

Comment 11

[(no longer active)]

I fixed the test.  The key was changing the 10px padding to 20px.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF41. I tried to open the STR link on FF40.0a2 2015-06-03 and do not see the problem, therefore setting FF40 status as "unaffected".

Comment 13

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/mozilla-central/rev/587e2801a239
(sorry to interfere, why wasn't this marked fixed?)

Comment 15

[TheRave]

Confirmed, its fixed.

Comment 16

[(no longer active)]

Comment on attachment 8623463 [details] [diff] [review]
Backout the second part of bug 1143570 to fix the regression

Approval Request Comment
[Feature/regressing bug #]: Bug 1143570 (part 2 patch)
[User impact if declined]: Comment 0, also see bug 1174834.
[Describe test coverage new/current, TreeHerder]: Has an automated test
[Risks and why]: Not risky, this is backing out an optimization patch landed in bug 1143570.
[String/UUID change made/needed]: None.

Comment 18

[Jorg K (CEST = GMT+2)]

Sorry to interfere: Why does this have an Aurora (Mozilla40) request? The original patch was never landed on Mozilla40, so it would be hard to back it out ;-)

Comment 19

[(no longer active)]

(In reply to Jorg K from comment #18)
> Sorry to interfere: Why does this have an Aurora (Mozilla40) request? The
> original patch was never landed on Mozilla40, so it would be hard to back it
> out ;-)

My mistake!