1174558 - Saturday periodic updates broken by bug 1145175 including more than the version text in version.txt

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

Bug 1145175 turned browser/config/version.txt from "41.0a1" to "41.0a1\n# Version to display in the about box:\n41.0a1".

Since the Saturday morning update of the in-tree blocklist and HSTS and HKPK data didn't know to expect that, it now tries to "wget -nv --no-check-certificate http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/firefox-41.0a1 # Version to display in the about box: 41.0a1.en-US.linux-x86_64.tar.bz2" which works just about as poorly as one would expect.

Comment 1

[Phil Ringnalda (:philor)]

http://mxr.mozilla.org/build/search?string=version.txt - might have also broken release tagging and mergeday, though I think not partner repacks with the readline(), probably.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Bug-1174558-Use-separate-file-for-the-about-window.-.patch

This is going to request to much work to manage the change in version.txt.
Especially this kind of declaration:

47             'browser/config/version.txt': {
48                 'version': releaseConfig['appVersion'],
49                 'nextVersion': releaseConfig['nextAppVersion']
50             },

in http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/staging_release-fennec-mozilla-beta.py

Let's go back to the two files solution

Comment 3

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68c24c8bf174

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68c24c8bf174