1174566 - [EME] Report more helpful messages when MediaKeySystemStatus rejects

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

When we reject a navigator.requestMediaKeySystemAccess() promise, we can provide a message string to help debug the reason for failure. We should provide more helpful strings. For example, in MediaKeySystemAccess::GetKeySystemStatus() we signal a reject for the "EME disabled" case, but we'll end up reporting a generic "not supported" error. GMPVideoDecoderTrialCreator seems to always reject with the same generic error message.

We should make these messages more helpful, so that we can debug in the field more easily.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Add more helpful exception messages when requestMediaKeySystemAccess rejects

* Add more helpful exception messages when requestMediaKeySystemAccess rejects.
* Remove the MP4Decoder::CanCreateH264Decoder() and MP4Decoder::CanCreateAACDecoder() checks from MediaKeySystemAccess::GetKeySystemStatus(), since it doesn't make much sense since we now have GMPTrialVideoCreator.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6fb494c349

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fd6fb494c349

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=588abc33bda3

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Beta try push that builds:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7645c670e21b

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

It's looking like we won't need this uplifted...