Closed Bug 1174566 Opened 4 years ago Closed 4 years ago

[EME] Report more helpful messages when MediaKeySystemStatus rejects

Categories

(Core :: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When we reject a navigator.requestMediaKeySystemAccess() promise, we can provide a message string to help debug the reason for failure. We should provide more helpful strings. For example, in MediaKeySystemAccess::GetKeySystemStatus() we signal a reject for the "EME disabled" case, but we'll end up reporting a generic "not supported" error. GMPVideoDecoderTrialCreator seems to always reject with the same generic error message.

We should make these messages more helpful, so that we can debug in the field more easily.
Priority: -- → P1
Assignee: nobody → cpearce
* Add more helpful exception messages when requestMediaKeySystemAccess rejects.
* Remove the MP4Decoder::CanCreateH264Decoder() and MP4Decoder::CanCreateAACDecoder() checks from MediaKeySystemAccess::GetKeySystemStatus(), since it doesn't make much sense since we now have GMPTrialVideoCreator.
Attachment #8626349 - Flags: review?(edwin)
https://hg.mozilla.org/mozilla-central/rev/fd6fb494c349
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
It's looking like we won't need this uplifted...
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.