1174590 - "360 Secure Browser" should be "360 Safe Browser"

Status: RESOLVED WONTFIX

(Firefox :: Migration, defect)

Description

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from bug 1164752 comment #23)
> (In reply to Francesco Lodolo [:flod] from bug 1164752 comment #22)
> > 
> > I find more results with "360 Safe Browser" than "360 Secure Browser", is
> > this the same product? Is there an official English name for it?
> > http://www.360.cn/about/englishversion.html
> 
> I believe it's the same product, both of these two translations are used, I
> don't really remember why I choosed this particular one.
> 
> I searched these two translations with "site:360.cn", it appears "360 Secure
> Browser" is used only once, while "360 Safe Browser" multiple times. I'll
> prepare a patch to change the strings to "360 Safe Browser". Thanks for
> bring this up.

Comment 1

[Hector Zhao [:hectorz]]

Attachment: MozReview Request: Bug 1174590 - "360 Secure Browser" should be "360 Safe Browser". r?mak

Bug 1174590 - "360 Secure Browser" should be "360 Safe Browser". r?mak

Comment 2

[Francesco Lodolo [:flod]]

https://reviewboard.mozilla.org/r/11209/#review9711

::: browser/locales/en-US/chrome/browser/migration/migration.properties:12
(Diff revision 1)
> -sourceName360se=360 Secure Browser
> +sourceName360se=360 Safe Browser

Same here: need a new string ID.

::: browser/locales/en-US/chrome/browser/migration/migration.dtd:22
(Diff revision 1)
> -<!ENTITY importFrom360se.label          "360 Secure Browser">
> +<!ENTITY importFrom360se.label          "360 Safe Browser">

You need a new string ID at this point (string already landed on mozilla-central).
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings

You'll also have to update the accesskey to keep the relation between the 2 strings (for localization tools).

Comment 3

[Marco Bonardo [:mak]]

I assume people most interested into this will use the chinese version of Firefox that will show the chinese name... Do we know what's the 360 Safe Browser marketshare out of China? It might not be that important at all...

Consider that also Wikipedia has a 360 Secure Browser page (https://en.wikipedia.org/wiki/360_Secure_Browser) but not a 360 Safe Browser page.

Comment 4

[Marco Bonardo [:mak]]

Based on the very low marketshare out of China and the fact both translation are clearly valid, plus the fact people tend to use wikipedia as a reference to check what's a certain product, I'd be prone to call this wontfix. Unless Francesco has strong arguments against that.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Marco Bonardo [::mak] from comment #4)
> Based on the very low marketshare out of China and the fact both translation
> are clearly valid, plus the fact people tend to use wikipedia as a reference
> to check what's a certain product, I'd be prone to call this wontfix. Unless
> Francesco has strong arguments against that.

No strong opinions either, I'm fine with keeping Secure, was mostly confused by the pages I found.
Also, my understanding it that the browser development has stopped recently?

Comment 6

[Hector Zhao [:hectorz]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> 
> Also, my understanding it that the browser development has stopped recently?

I think that's the "360 Browser" from http://www.360safe.com/browser.html, which is not covered by this migrator.

Comment 7

[Marco Bonardo [:mak]]

ok, resolving then, based on comment 4.