1174645 - Jobs with missing logs incorrectly say " Log parsing complete. Generating bug suggestions The content of this panel will refresh in 5 seconds."

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

See jobs in:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4edd6b30d540&filter-searchStr=b2g%20desktop&filter-resultStatus=retry

Comment 1

[Ed Morley [:emorley]]

 Log parsing status: failed 

...since the log is 404:
https://queue.taskcluster.net/v1/task/IT1ZYAulREO4IqODafW2Cg/runs/0/artifacts/public/logs/live_backing.log

Comment 2

[Ed Morley [:emorley]]

See also this log:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6411f2fcd3ec&filter-searchStr=Windows%208%20x64%20debug%20Mochitest%20Mochitest%20M%282%29

...which isn't 404, but yet has a parsing status of "failed". 

Either way, we shouldn't display the "Log parsing complete. Generating bug suggestions..." message if we're not going to retry the parse.

Comment 3

[Jonathan French (:jfrench)]

Tapesh expressed interest in fixing this bug, so assigning. Thanks Tapesh!

Comment 4

[Ed Morley [:emorley]]

I'm probably not the best to mentor this; clearing mentor.

Comment 5

[Tapesh Mandal]

Hi Ed,

No problem ..still thanks :)

Regards,
Tapesh Mandal

Comment 6

[Tapesh Mandal]

Attachment: Bug 1174645 - Jobs with missing logs incorrectly say " Log parsing complete. Generating bug suggestions The content of this panel will refresh in 5 seconds."

Hi all ,

i hope the changes made in the pull request are satisfactory \:)

Regards,
Tapesh Mandal

Comment 7

[Jonathan French (:jfrench)]

Comment on attachment 8666905 [details] [review]
Bug 1174645 - Jobs with missing logs incorrectly say " Log parsing complete. Generating bug suggestions The content of this panel will refresh in 5 seconds."

I left some comments in the PR.

Comment 8

[Cameron Dawson [:camd]]

Comment on attachment 8666905 [details] [review]
Bug 1174645 - Jobs with missing logs incorrectly say " Log parsing complete. Generating bug suggestions The content of this panel will refresh in 5 seconds."

Hi Tapesh--  I made some comments in the PR.  I think we should take a different approach.  I apologize for confirming this approach, initially.  After playing with your solution I realized we needed to do this a little differently.  

Thanks for all your work!  I'm clearing the review for now.  Please re-add me when you have made your adjustments.

Comment 9

[Tapesh Mandal]

Hi camd,jfrench ,

Made changes as suggested by both of you. Please test it and let me know. works fine on my system according to Ed's testcases.

Regards,
Tapesh Mandal

Comment 10

[Tapesh Mandal]

(In reply to Tapesh Mandal from comment #9)
> Hi camd,jfrench ,
> 
> Made changes as suggested by both of you. Please test it and let me know.
> works fine on my system according to Ed's testcases.
> 
> Regards,
> Tapesh Mandal

Test as required :)

Comment 11

[Jonathan French (:jfrench)]

I've provided some feedback in the PR, some of the linting changes are appreciated but are a bit outside the scope of the code involved, we can reduce those and do them in another P5 bug.

I'll let Tapesh re-test the test cases I've outlined earlier (running, pending, coalesced) in addition to Ed's above, and sanity testing of the change in related functionality vs. production which should match in all other respects except for the fix. Thanks Tapesh! :)

Comment 12

[Cameron Dawson [:camd]]

This looks great!  Good to merge.

Comment 13

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/608f0f6beaa87e438ea58ea4518e531958a40789
Bug 1174645 - Improve job details message for missing logs

https://github.com/mozilla/treeherder/commit/58ae256b28e0ad6dba32c91efce8096ed6a88a2a
Merge pull request #1012 from mandaltapesh/logparse

Bug 1174645 - Improve job details message for missing logs

Comment 14

[Cameron Dawson [:camd]]

Thanks for tackling this, Tapesh!

Comment 15

[Tapesh Mandal]

My pleasure :)