1174683 - [Secure Element] Fix TypeErro in UiccConnector unregisterListener

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

As pointed out by Yoshi in Bug 1119152 comment 23

> +  unregisterListener: function(listener) {
> +    let idx = this._SEListeners.indexOf(listener);
> +    if (idx !== -1) {
> +      this._listeners.splice(idx, 1);


[JavaScript Error: "TypeError: this._listeners is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/UiccConnector.js" line: 331}]

Comment 2

[Krzysztof Mioduszewski[:tauzen]]

Attachment: 0001-Bug-1174683-Secure-Element-Fix-TypeError-in-UiccConn.patch

Hi Yoshi, could you review this? This is a typo done while I was refactoring the isSEPresent patch.

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=432967b3d0f2

Comment 4

[Krzysztof Mioduszewski[:tauzen]]

Try build mostly green, 3 unrelated failures.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/4b827038a8c5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b827038a8c5

Comment 7

[Maria Angeles Oteo (:oteo)]

As NGA Program Manager suggested, let's replace the NGA-Sx milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed