Closed
Bug 1174683
Opened 7 years ago
Closed 7 years ago
[Secure Element] Fix TypeErro in UiccConnector unregisterListener
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
FxOS-S1 (26Jun)
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: tauzen, Assigned: tauzen)
References
Details
Attachments
(1 file)
1.11 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
As pointed out by Yoshi in Bug 1119152 comment 23 > + unregisterListener: function(listener) { > + let idx = this._SEListeners.indexOf(listener); > + if (idx !== -1) { > + this._listeners.splice(idx, 1); [JavaScript Error: "TypeError: this._listeners is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/UiccConnector.js" line: 331}]
Assignee: nobody → kmioduszewski
Blocks: b2g-secure-element
Assignee | ||
Comment 2•7 years ago
|
||
Hi Yoshi, could you review this? This is a typo done while I was refactoring the isSEPresent patch.
Attachment #8622409 -
Flags: review?(allstars.chh)
Updated•7 years ago
|
Attachment #8622409 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 3•7 years ago
|
||
try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=432967b3d0f2
Assignee | ||
Comment 4•7 years ago
|
||
Try build mostly green, 3 unrelated failures.
Keywords: checkin-needed
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4b827038a8c5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → NGA S3 (26Jun)
Comment 7•7 years ago
|
||
As NGA Program Manager suggested, let's replace the NGA-Sx milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in
before you can comment on or make changes to this bug.
Description
•