[Secure Element] Fix TypeErro in UiccConnector unregisterListener

RESOLVED FIXED in Firefox 41

Status

Product:
Firefox OS Graveyard
Component:
NFC
Type:
defect
Status:
RESOLVED FIXED
Opened:
4 years ago
Updated:
4 years ago

People

(Reporter: tauzen, Assigned: tauzen)

Tracking

Version:
unspecified
Target:
FxOS-S1 (26Jun)
Platform:
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

0001-Bug-1174683-Secure-Element-Fix-TypeError-in-UiccConn.patch
1.11 KB, patch
allstars.chh
: review+
Details | Diff | Splinter Review 
No description provided.
Blocks: 1119152
As pointed out by Yoshi in Bug 1119152 comment 23

> +  unregisterListener: function(listener) {
> +    let idx = this._SEListeners.indexOf(listener);
> +    if (idx !== -1) {
> +      this._listeners.splice(idx, 1);


[JavaScript Error: "TypeError: this._listeners is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/UiccConnector.js" line: 331}]
Assignee: nobody → kmioduszewski
Blocks: b2g-secure-element
Hi Yoshi, could you review this? This is a typo done while I was refactoring the isSEPresent patch.
Attachment #8622409 - Flags: review?(allstars.chh)
Attachment #8622409 - Flags: review?(allstars.chh) → review+
Try build mostly green, 3 unrelated failures.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4b827038a8c5
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → NGA S3 (26Jun)
As NGA Program Manager suggested, let's replace the NGA-Sx milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in before you can comment on or make changes to this bug.