1174717 - [bluetooth2] Passing fallible when calling AppendElement method for Sequence types in bluetooth2.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

bluetooth2 build failed since Bug 968520 landed.
We should pass fallible argument when calling AppendElement method for Sequence types used in bluetooth2.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1174717 - Passing fallible when calling AppendElement method for Sequence types in bluetooth2.

Hi Shawn,

Please help to review my patch.

Thanks,
Jocelyn

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8622459 [details] [diff] [review]
Bug 1174717 - Passing fallible when calling AppendElement method for Sequence types in bluetooth2.

Review of attachment 8622459 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothCommon.h
@@ +131,5 @@
> +    uint32_t index = uint32_t(enumValue);                            \
> +    nsAutoString name;                                               \
> +    name.AssignASCII(enumType##Values::strings[index].value,         \
> +                     enumType##Values::strings[index].length);       \
> +    array.AppendElement(name, fallible);                             \

Can we write |mozilla::fallible|? That would be easier to understand.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1174717 - Passing fallible when calling AppendElement method for Sequence types in bluetooth2. r=shuang

- s/fallible/mozilla::fallible

Thanks, Shawn.

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

No try server result since bluetooth2 won't be built on try server.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/62c57bdc3364

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/62c57bdc3364

Comment 7

[Maria Angeles Oteo (:oteo)]

As NGA Program Manager suggested, let's replace the NGA-Sx milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed