Text between "Browser compatiblilty" header and the compat table breaks import tool

RESOLVED FIXED

Status

Mozilla Developer Network
BrowserCompat
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: sheppy, Assigned: jwhitlock)

Tracking

Details

(Whiteboard: [bc:infra])

(Reporter)

Description

3 years ago
What did you do?
================
See this issue: https://browsercompat.herokuapp.com/importer/2840

Which is on this page: https://developer.mozilla.org/en-US/docs/Web/API/MozSmsMessage

What happened?
==============
The problem is the existence of text in space where the importer expects a table. Causes an error to occur.

What should have happened?
==========================
This text should be ignored during import or, possibly, placed in a comment somewhere, if there's an appropriate place to do so.

Is there anything else we should know?
======================================
(Reporter)

Updated

3 years ago
Blocks: 1132269
I think we should just remove this comment. It is not really bringing any information.
(Assignee)

Comment 2

3 years ago
The parser could turn this into an issue, rather than stopping parsing.  This will require the changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1171957 (refactor scraper), This won't fix the issue, but will allow parsing to continue.

Actual solutions require fixing the page:
1. The comment could be moved into the table, in the third cell, and imported into the API as a note for the specification section
2. The comment could be changed into a footnote in the compatibility table, and imported into the API as a support note
3. New KumaScript, similar to WhyNoSpecStart / WhyNoSpecEnd, could be introduced, and the parser taught to ignore it.
4. The text can be moved to a new section, retaining it on MDN but not in the compatibility API
5. The text can be removed

In this specific case, the text is:

This is a non standard implementation, but it is discussed at W3C as part of the System Application Working Group.

This feels like solution #2 - a support note for Firefox Mobile support.
Keywords: in-triage
(Assignee)

Updated

3 years ago
Blocks: 1181140
No longer blocks: 1132269
Summary: Text between "Browser compatiblilty" header and the compat table breaks import tool → [Compat Data][Importer] Text between "Browser compatiblilty" header and the compat table breaks import tool
(Assignee)

Updated

3 years ago
Assignee: nobody → jwhitlock
Status: NEW → ASSIGNED
Component: General → BrowserCompat
(Assignee)

Comment 3

2 years ago
Fixed with bug 1181140
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Keywords: in-triage
OS: Other → All
Summary: [Compat Data][Importer] Text between "Browser compatiblilty" header and the compat table breaks import tool → Text between "Browser compatiblilty" header and the compat table breaks import tool
Whiteboard: [specification][type:bug] → [bc:infra]
You need to log in before you can comment on or make changes to this bug.