Closed Bug 1174851 Opened 10 years ago Closed 10 years ago

Intermittent browser_readerMode_hidden_nodes.js | Test timed out

Categories

(Toolkit :: Reader Mode, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- unaffected
firefox40 --- unaffected
firefox41 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: RyanVM, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure)

10:17:14 INFO - 428 INFO TEST-START | browser/base/content/test/general/browser_readerMode_hidden_nodes.js 10:17:17 INFO - JavaScript error: , line 0: NetworkError: A network error occurred. 10:17:17 INFO - JavaScript error: , line 0: NetworkError: A network error occurred. 10:17:59 INFO - Xlib: extension "RANDR" missing on display ":0". 10:18:01 INFO - TEST-INFO | screentopng: exit 0 10:18:01 INFO - 429 INFO checking window state 10:18:01 INFO - 430 INFO Entering test test_reader_button 10:18:01 INFO - 431 INFO TEST-PASS | browser/base/content/test/general/browser_readerMode_hidden_nodes.js | Element should not be null, when checking visibility 10:18:01 INFO - 432 INFO TEST-PASS | browser/base/content/test/general/browser_readerMode_hidden_nodes.js | Reader mode button is not present on a new tab 10:18:01 INFO - 433 INFO Wait tab event: load 10:18:01 INFO - 434 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/browser/base/content/test/general/readerModeArticleHiddenNodes.html" line: 0}] 10:18:01 INFO - 435 INFO Tab event received: load 10:18:01 INFO - 436 INFO Console message: [JavaScript Error: "NetworkError: A network error occurred."] 10:18:01 INFO - 437 INFO Console message: [JavaScript Error: "NetworkError: A network error occurred."] 10:18:01 INFO - 438 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_readerMode_hidden_nodes.js | Test timed out - expected PASS 10:18:01 INFO - MEMORY STAT vsize after test: 21991871655936 10:18:01 INFO - MEMORY STAT residentFast after test: 758071296 10:18:01 INFO - 439 INFO TEST-OK | browser/base/content/test/general/browser_readerMode_hidden_nodes.js | took 45377ms
Blocks: 1172270
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Right. So what's happening here is this is failing on reasonably-fast non-Windows e10s machines. The reason it's failing seems to be the fact that we listen for the tab to load in the parent process, then have another delay due to the implicit-async yield in the test, and then start listening for mozafterpaint. That misses the event, and on non-Windows (hi, vsync) and e10s (why would I paint anything in the static content area?) this means there are no more paint events until you do something to the content window (the test never does this) and the test then times out. Locally, I could get it to not time out by e.g. selecting some text in the content area, causing a paint, and kicking the rest of the test into action. The code it's testing doesn't have this problem because it listens in the content process and then immediately attaches the new event handler (no async delays) and so it always gets called (I could repro this all locally so the correctness of the actual code was the first thing I checked). The thing I just checked in simply changes the test to mimic the actual code more closely, and listens for all the events in the content process instead of the parent process. This fixed the race condition for me locally.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.