Closed Bug 1174868 Opened 5 years ago Closed 5 years ago

Avoid storing RequestContext inside InternalRequest

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

We are going to infer all RequestContext types from the corresponding
nsContentPolicyType. It no longer makes sense to store both of these on
InternalRequest.  This has the extra benefit that we don't need to worry
about keeping them in sync any more.
Asking review from smaug on the WebIDL change, bkelly on the cache changes and nsm on the rest.
Attachment #8622660 - Flags: review?(nsm.nikhil)
Attachment #8622660 - Flags: review?(bugs)
Attachment #8622660 - Flags: review?(bkelly)
Assignee: nobody → ehsan
Blocks: 1121157
Comment on attachment 8622660 [details] [diff] [review]
Avoid storing RequestContext inside InternalRequest

Review of attachment 8622660 [details] [diff] [review]:
-----------------------------------------------------------------

Any reason to do the cache bits in bug 1174849 if we're going to do this?  Seems like this supersedes the other one.
Attachment #8622660 - Flags: review?(bkelly) → review+
(In reply to Ben Kelly [:bkelly] from comment #2)
> Comment on attachment 8622660 [details] [diff] [review]
> Avoid storing RequestContext inside InternalRequest
> 
> Review of attachment 8622660 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Any reason to do the cache bits in bug 1174849 if we're going to do this? 
> Seems like this supersedes the other one.

It's very likely that I will land both patches together, but I would like to test this a bit more.  Doesn't matter much either way...
Comment on attachment 8622660 [details] [diff] [review]
Avoid storing RequestContext inside InternalRequest

It would be nice if webidl enum or some consts were used in .webidl.
But fine.
Attachment #8622660 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/00f970918639
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.