1174868 - Avoid storing RequestContext inside InternalRequest

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[:ehsan akhgari]

We are going to infer all RequestContext types from the corresponding
nsContentPolicyType. It no longer makes sense to store both of these on
InternalRequest.  This has the extra benefit that we don't need to worry
about keeping them in sync any more.

Comment 1

[:ehsan akhgari]

Attachment: Avoid storing RequestContext inside InternalRequest

Asking review from smaug on the WebIDL change, bkelly on the cache changes and nsm on the rest.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8622660 [details] [diff] [review]
Avoid storing RequestContext inside InternalRequest

Review of attachment 8622660 [details] [diff] [review]:
-----------------------------------------------------------------

Any reason to do the cache bits in bug 1174849 if we're going to do this?  Seems like this supersedes the other one.

Comment 3

[:ehsan akhgari]

(In reply to Ben Kelly [:bkelly] from comment #2)
> Comment on attachment 8622660 [details] [diff] [review]
> Avoid storing RequestContext inside InternalRequest
> 
> Review of attachment 8622660 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Any reason to do the cache bits in bug 1174849 if we're going to do this? 
> Seems like this supersedes the other one.

It's very likely that I will land both patches together, but I would like to test this a bit more.  Doesn't matter much either way...

Comment 4

[Olli Pettay [:smaug]]

Comment on attachment 8622660 [details] [diff] [review]
Avoid storing RequestContext inside InternalRequest

It would be nice if webidl enum or some consts were used in .webidl.
But fine.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00f970918639

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00f970918639