1174877 - Import phanalysis / graph server alert code into treeherder

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

To implement bug 1150152 and other things, we should import the graphserver analysis (and my subsequent modifications to it) into the treeherder. For historical / archival purposes, let's import the full history from http://hg.mozilla.org/graphs/.

We'll use the same strategy as we did with the client and ui -> rewrite history so things appear to always have been in the correct subdirectory (treeherder/phanalysis/phanalysis for this particular case)

Comment 1

[William Lachance (:wlach)]

Attachment: PR

Hi Ed, I don't expect you to understand the code completely, but you're probably the one who knows the most about merging repositories, which is what's really going on here (and where there is the most potential to go wrong).

The unit tests are passing and the API (while imperfect) is I think at least enough to get started, so if that's good enough I think I'm just going to put this in. We can always improve things as we go along later.

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8622687 [details] [review]
PR

The tests are failing at the moment, did you mean to add the file as:
 treeherder/phanalysis/__init__.py 

Rather than:
 treeherder/phanalysis/phanalysis/__init__.py 
?

I'm not sure I understand the name phanalysis? (It's hard to say for a start :-))

Comment 3

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #2)
> I'm not sure I understand the name phanalysis? (It's hard to say for a start
> :-))

Oh "ph" -> perfherder?
Maybe perf-analysis or perf-analyser is clearer? (Or something else?)

Comment 4

[William Lachance (:wlach)]

(In reply to Ed Morley [:emorley] from comment #2)
> Comment on attachment 8622687 [details] [review]
> PR
> 
> The tests are failing at the moment, did you mean to add the file as:
>  treeherder/phanalysis/__init__.py 
> 
> Rather than:
>  treeherder/phanalysis/phanalysis/__init__.py 
> ?

Yes, I forgot to add some files. This has been fixed!

(In reply to Ed Morley [:emorley] from comment #3)
> (In reply to Ed Morley [:emorley] from comment #2)
> > I'm not sure I understand the name phanalysis? (It's hard to say for a start
> > :-))
> 
> Oh "ph" -> perfherder?
> Maybe perf-analysis or perf-analyser is clearer? (Or something else?)

Maybe perfherder-alerts is clearest, since the only intention of this code is to generate such things. I'll sleep on it, in the mean time I think the patch should be ready for review again.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8622687 [details] [review]
PR

Tests, etc. should be passing again.

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8622687 [details] [review]
PR

I'm still not really a fan of the name "phanalysis", but from a merging in POV this looks ok. Will leave it up to you if you change the name or not.

Comment 7

[William Lachance (:wlach)]

This has been merged. I renamed phanalysis to perfalert.