Closed Bug 1174878 Opened 5 years ago Closed 5 years ago

Update robocop test testSettingsMenuItems.java to use StringHelper.java in all cases

Categories

(Firefox for Android :: Testing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: ally, Assigned: ally)

Details

Attachments

(1 file, 1 obsolete file)

This came out as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1136477#c32 where this test has a number of hardcoded strings and so is prone to bustage.

The vast majority of those strings are not related to the logins or passwords, so breaking this out into its own bug.
Assignee: nobody → ally
Whilst the dust settles after 42...
Status: NEW → ASSIGNED
Attached patch updateRobocopTest (obsolete) — Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b2600900536

needs to be more properly grouped and trailing space clean up from intellij
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d236d4b354d4

I tried to group the strings as best I could.

If you try to build it locally, beware: testSettings bitrots on every single pull. This one is built on top of the fx-team changeset: 258209:c9e9cc44bed8
Attachment #8646665 - Attachment is obsolete: true
Attachment #8649543 - Flags: review?(liuche)
Comment on attachment 8649543 [details] [diff] [review]
updateRobocopTest

Review of attachment 8649543 [details] [diff] [review]:
-----------------------------------------------------------------

Just one nit! This looks good, thanks for doing this :) This cleans up this test a lot.

::: mobile/android/tests/browser/robocop/testSettingsMenuItems.java
@@ +71,2 @@
>                  { mStringHelper.IMPORT_FROM_ANDROID_LABEL, "", "Bookmarks", "History", "Import" },
> +                { mStringHelper.CUSTOMIZE_HOME},

Actually, move these all back above the IMPORT_FROM_ANDROID_LABEL. It shouldn't matter for this test right now, but the way we find strings is by scrolling down, so that might make a difference in the future.
Attachment #8649543 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/c9d91ba09a2f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.