1174878 - Update robocop test testSettingsMenuItems.java to use StringHelper.java in all cases

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Allison Naaktgeboren :ally]

This came out as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1136477#c32 where this test has a number of hardcoded strings and so is prone to bustage.

The vast majority of those strings are not related to the logins or passwords, so breaking this out into its own bug.

Comment 1

[Allison Naaktgeboren :ally]

Whilst the dust settles after 42...

Comment 2

[Allison Naaktgeboren :ally]

Attachment: updateRobocopTest

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b2600900536

needs to be more properly grouped and trailing space clean up from intellij

Comment 3

[Allison Naaktgeboren :ally]

Attachment: updateRobocopTest

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d236d4b354d4

I tried to group the strings as best I could.

If you try to build it locally, beware: testSettings bitrots on every single pull. This one is built on top of the fx-team changeset: 258209:c9e9cc44bed8

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8649543 [details] [diff] [review]
updateRobocopTest

Review of attachment 8649543 [details] [diff] [review]:
-----------------------------------------------------------------

Just one nit! This looks good, thanks for doing this :) This cleans up this test a lot.

::: mobile/android/tests/browser/robocop/testSettingsMenuItems.java
@@ +71,2 @@
>                  { mStringHelper.IMPORT_FROM_ANDROID_LABEL, "", "Bookmarks", "History", "Import" },
> +                { mStringHelper.CUSTOMIZE_HOME},

Actually, move these all back above the IMPORT_FROM_ANDROID_LABEL. It shouldn't matter for this test right now, but the way we find strings is by scrolling down, so that might make a difference in the future.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c9d91ba09a2f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c9d91ba09a2f