1175040 - Box-model view server-side code clean-up and getLayout should send more properties

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

A lot of things I want to do in bug 1150496 require the pageStyleActor.getLayout method to send more data about the current node. Right now it basically only sends back the sizes of each of the box-model regions. I want it to also send the computed values of various css properties: box-sizing, display, position, z-index.

I'd also like to take this opportunity to do some eslint-related cleanup to styles.js

Comment 1

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1175040 - Add more layout-related properties to the output of getLayout; r=bgrins

Bug 1175040 - Eslint cleanups in styles.js and highlighter.js actor modules; r?bgrins

Comment 2

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1175040 - Add more layout-related properties to the output of getLayout; r?bgrins

Bug 1175040 - Add more layout-related properties to the output of getLayout; r?bgrins

The getLayout method of the PageStyleActor returns layout-related data about an element
but some information is missing. In particular, this patch adds data about the
box-sizing, display and z-index. All of which will be very useful when adding more
information to the layoutview panel in bug 1150496.

Comment 3

[Patrick Brosset <:pbro>]

(In reply to Patrick Brosset [:pbrosset] [:patrick] [:pbro] from comment #1)
> Created attachment 8623563 [details]
> MozReview Request: Bug 1175040 - Eslint cleanups in styles.js and
> highlighter.js actor modules; r?bgrins
> 
> Bug 1175040 - Eslint cleanups in styles.js and highlighter.js actor modules;
> r?bgrins
I got a bit carried away with this one and also ended up making eslint cleanups to highlighter.js (which I intend to work on in the scope of bug 1150496 anyway, namely to land the work we did earlier in bug 938188).

Comment 4

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cc134f723e7

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8623563 [details]
MozReview Request: Bug 1175040 - Add more layout-related properties to the output of getLayout; r=bgrins

https://reviewboard.mozilla.org/r/11571/#review10001

Nice!  Looks mechanical enough, so assuming tests are all still passing let's ship it

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8623564 [details]
MozReview Request: Bug 1175040 - Add more layout-related properties to the output of getLayout; r?bgrins

https://reviewboard.mozilla.org/r/11573/#review10005

Doesn't look like we have a server-side test for getLayout yet, this would be a great oppurtunity to add one (or modify one of the existing test_styles-* functions to include this function

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e798232c7a8a

Comment 8

[Patrick Brosset <:pbro>]

Comment on attachment 8623563 [details]
MozReview Request: Bug 1175040 - Add more layout-related properties to the output of getLayout; r=bgrins

Bug 1175040 - Add more layout-related properties to the output of getLayout; r=bgrins

The getLayout method of the PageStyleActor returns layout-related data about an element
but some information is missing. In particular, this patch adds data about the
box-sizing, display and z-index. All of which will be very useful when adding more
information to the layoutview panel in bug 1150496.

Comment 9

[Patrick Brosset <:pbro>]

https://reviewboard.mozilla.org/r/11571/#review10073

::: toolkit/devtools/server/actors/styles.js
(Diff revision 2)
> -    if (options.margins) {

This looked like a leftover from ancient times I think. No-one uses this option, and it does the same as autoMargins (which on the contrary, is used).

Comment 10

[Patrick Brosset <:pbro>]

The previous, more complete, try build was green. Here's one more just with chrome mochitests to make sure the new test I added works fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=384c56e5183e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e798232c7a8a

Comment 12

[Brian Grinstead [:bgrins]]

Comment on attachment 8623563 [details]
MozReview Request: Bug 1175040 - Add more layout-related properties to the output of getLayout; r=bgrins

https://reviewboard.mozilla.org/r/11571/#review10175

Ship It!

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cfdfff0c6963

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfdfff0c6963