1175057 - [Wifi] Script timeout in test_wifi_static_ip.js (breaked by bug 1166660)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect, P2)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a follow-up of Bug #1166660 +++

I found the changes in bug 1166660 break the test_wifi_static_ip.js test.

[1] https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=3fb87cd8044c&exclusion_profile=false&filter-searchStr=mnw

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Using the custom hostapd instead of stock hostapd (like we did in bug 1166660) can also fix this, but I am not sure if this is a good idea to fix it.

Comment 2

[Henry Chang [:hchang]]

It seems while running 'test_wifi_static_ip.js', there are 4 APs out there
(supposed to have only the stock AP). I believe I didn't deal with stock AP
very well when fixing KK emulator.

Since the use of stock AP has been removed in order to fix KK emulator test cases,
this issue will be only observed in this test case.

Comment 3

[Henry Chang [:hchang]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8623451 [details] [diff] [review]
> Patch, v1
> 
> Using the custom hostapd instead of stock hostapd (like we did in bug
> 1166660) can also fix this, but I am not sure if this is a good idea to fix
> it.

Oops! I think it is just because all the APs are killed in the previous
test case (test_wifi_auto_connect.js). 

Pushed a patch to try. The patch simply restart hostapd every time
we are about to run a test case chain.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5a9e0a6d5ac

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug-1175057.patch

Comment 5

[Tim Huang[:timhuang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6c6b7f992a3

Comment 6

[Henry Chang [:hchang]]

Comment on attachment 8655313 [details] [diff] [review]
Bug-1175057.patch

Review of attachment 8655313 [details] [diff] [review]:
-----------------------------------------------------------------

It looks pretty good :) Let's wait for the try run result!

Comment 7

[Edgar Chen [:edgar]]

Right now, the marionette-webapi is broken by https://bugzilla.mozilla.org/show_bug.cgi?id=1050749#c44 :(.
You can push to try again after it is fixed.

Comment 8

[Edgar Chen [:edgar]]

Bug 1200960 is landed, you can try it again with latest gecko. ;)

Comment 9

[Tim Huang[:timhuang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba8ff777c1bd

Comment 10

[Tim Huang[:timhuang]]

Attachment: Bug-1175057-already-reviewed-by-hchang.patch

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7d271e866fa2

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d271e866fa2