If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Wifi] Script timeout in test_wifi_static_ip.js (breaked by bug 1166660)

RESOLVED FIXED in Firefox 43

Status

Firefox OS
Wifi
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: edgar, Assigned: timhuang)

Tracking

unspecified
FxOS-S7 (18Sep)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

2 years ago
+++ This bug was initially created as a follow-up of Bug #1166660 +++

I found the changes in bug 1166660 break the test_wifi_static_ip.js test.

[1] https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=3fb87cd8044c&exclusion_profile=false&filter-searchStr=mnw
(Reporter)

Comment 1

2 years ago
Created attachment 8623451 [details] [diff] [review]
Patch, v1

Using the custom hostapd instead of stock hostapd (like we did in bug 1166660) can also fix this, but I am not sure if this is a good idea to fix it.
It seems while running 'test_wifi_static_ip.js', there are 4 APs out there
(supposed to have only the stock AP). I believe I didn't deal with stock AP
very well when fixing KK emulator.

Since the use of stock AP has been removed in order to fix KK emulator test cases,
this issue will be only observed in this test case.
(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8623451 [details] [diff] [review]
> Patch, v1
> 
> Using the custom hostapd instead of stock hostapd (like we did in bug
> 1166660) can also fix this, but I am not sure if this is a good idea to fix
> it.

Oops! I think it is just because all the APs are killed in the previous
test case (test_wifi_auto_connect.js). 

Pushed a patch to try. The patch simply restart hostapd every time
we are about to run a test case chain.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5a9e0a6d5ac

Updated

2 years ago
Priority: -- → P2
(Assignee)

Comment 4

2 years ago
Created attachment 8655313 [details] [diff] [review]
Bug-1175057.patch
Attachment #8655313 - Flags: review?(hchang)
(Assignee)

Updated

2 years ago
Attachment #8655313 - Attachment description: Fix the problem of the script timeout by ensuring it associates to the right ap. → Bug-1175057.patch
(Assignee)

Comment 5

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6c6b7f992a3
Comment on attachment 8655313 [details] [diff] [review]
Bug-1175057.patch

Review of attachment 8655313 [details] [diff] [review]:
-----------------------------------------------------------------

It looks pretty good :) Let's wait for the try run result!
Attachment #8655313 - Flags: review?(hchang) → review+
(Reporter)

Comment 7

2 years ago
Right now, the marionette-webapi is broken by https://bugzilla.mozilla.org/show_bug.cgi?id=1050749#c44 :(.
You can push to try again after it is fixed.
(Reporter)

Comment 8

2 years ago
Bug 1200960 is landed, you can try it again with latest gecko. ;)
(Reporter)

Updated

2 years ago
Attachment #8623451 - Attachment is obsolete: true
(Assignee)

Comment 9

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba8ff777c1bd
(Assignee)

Updated

2 years ago
Assignee: nobody → tihuang
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 10

2 years ago
Created attachment 8656939 [details] [diff] [review]
Bug-1175057-already-reviewed-by-hchang.patch
Attachment #8656939 - Flags: review+
(Assignee)

Updated

2 years ago
Attachment #8655313 - Attachment is obsolete: true

Comment 11

2 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/7d271e866fa2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7d271e866fa2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.