Closed Bug 117509 Opened 22 years ago Closed 22 years ago

Templatise createaccount.cgi

Categories

(Bugzilla :: User Accounts, defect, P2)

Product:
Bugzilla
Component:
User Accounts
Version:
2.15
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file)

Patch v.1
11.39 KB, patch
dkl
: review+
bbaetz
: review+
Details | Diff | Splinter Review 
Templates, templates everywhere, but not a sec to think...

Gerv
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.16
Attached patch Patch v.1 — — Splinter Review 
Try this on for size. I've tried to localise the changes by purposefully not
templatising one part; read the patch to see. As always, best reviewed as whole
files, not as patches.

Gerv
Comment on attachment 63123 [details] [diff] [review]
Patch v.1

Code looks clean and everything worked as expected for my test installation.

r=dkl
Attachment #63123 - Flags: review+
Keywords: patch
Keywords: review
Comment on attachment 63123 [details] [diff] [review]
Patch v.1

WFM r=bbaetz
Attachment #63123 - Flags: review+
Checked in.

Gerv
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.