I mentioned this to mpt last night and he agreed. I forgot to post this, but bug 117516 reminded me.
Doron, wanna whip up a quick patch? :)
I still don't see why it should be there. It should go to the mail&news pref panel I think.
Doron, I would agree with you IFF the pref for Enabling JS in Navigator gets moved to the Navigator panel. Having one pref in Mail/News and the other in Advanced makes no sense. They either both need to be in advanced or else in Navigator and Mail/News, respectively.
mpt, care to explain?
cc'ing jennifer and marlon for their input.
Doron, You are welcome to take this bug if you can spare the cycles for it.
-> moi So what should be done? Move the mailnews pref to the "scripts and windows" panel?
Yes, that would be consistent.
New screenshot: http://www.nexgenmedia.net/mozilla/pref-scripts.png. Contains fixes for 115353 as well
I agree with the addition of "for Navigator". As for moving the checkbox out of the groupbox, that makes sense as well. Any objections?
Created attachment 64359 [details] [diff] [review] patch Screenshot at: http://nexgenmedia.net/mozilla/pref-scripts.png (matches jglick's picture)
Created attachment 64677 [details] [diff] [review] better patch new patch
could I see a diff -wu just for clarity?
Comment on attachment 64677 [details] [diff] [review] better patch I got a newer version without the evil overlay hack
Created attachment 64866 [details] [diff] [review] newest patch new patch has no evil overlay hack. If you need a diff -wu, shout at me
Created attachment 65070 [details] [diff] [review] new patch that applies previous patch wouldn't apply correctly, this should fix it
Created attachment 65079 [details] [diff] [review] really appliable patch Sorry about this, something was wrong in my local version of a file that caused wierd diff issues
Created attachment 65091 [details] [diff] [review] really really appliable patch Added an newline to make it apply, thanks to db48x for figuring that out. No idea what is wrong with 'diff' here
Comment on attachment 65091 [details] [diff] [review] really really appliable patch and on that note, r=db48x
cc: alecf for superreview
ok, I'm shouting at you for a -wu version... :)
Comment on attachment 65091 [details] [diff] [review] really really appliable patch seems reasonable. sr=alecf
fix checked in.
verified fixed using 2002.01.29.1x comm verif bits on linux rh7.2, win2k and mac 10.1.2.