If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move "Enable Javascript for Mail/News" to the new Scripts/Windows pref pane

VERIFIED FIXED in mozilla0.9.9

Status

SeaMonkey
Preferences
P2
normal
VERIFIED FIXED
16 years ago
12 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Doron Rosenberg (IBM))

Tracking

Trunk
mozilla0.9.9

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 6 obsolete attachments)

I mentioned this to mpt last night and he agreed.  I forgot to post this, 
but bug 117516 reminded me.
Doron, wanna whip up a quick patch?  :)
(Assignee)

Comment 2

16 years ago
I still don't see why it should be there. It should go to the mail&news pref
panel I think.
Doron, I would agree with you IFF the pref for Enabling JS in Navigator gets
moved to the Navigator panel.  Having one pref in Mail/News and the other in
Advanced makes no sense.  They either both need to be in advanced or else in
Navigator and Mail/News, respectively.
mpt, care to explain?
cc'ing jennifer and marlon for their input.

Comment 6

16 years ago
I'd agree. Enabling javascript is an advanced setting.

Comment 7

16 years ago
Doron, 
You are welcome to take this bug if you can spare the cycles for it.
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 8

16 years ago
-> moi

So what should be done?

Move the mailnews pref to the "scripts and windows" panel?
Assignee: sgehani → doronr

Comment 9

16 years ago
Yes, that would be consistent.

Updated

16 years ago
Blocks: 115353
(Assignee)

Comment 10

16 years ago
New screenshot: http://www.nexgenmedia.net/mozilla/pref-scripts.png. Contains
fixes for 115353 as well

Comment 11

16 years ago
Does the first groupbox if items apply to the browser only? Maybe the label 
could say that?  "Enable JavaScript for Navigator."
Don't the grouped prefs in the "Allow scripts to" group apply globally? (both
mailnews and browser)

IIRC they do, so we probably should move both Enable prefs outside of the
groupbox (above it preferably).

jglick, yes the pref that currently says 'Enable Javascript' is for browser
only, so I agree it should have something about Navigator in it's label.
(Assignee)

Comment 13

16 years ago
I agree with the addition of "for Navigator".  As for moving the checkbox out of
the groupbox, that makes sense as well. Any objections?

Comment 14

16 years ago
Created attachment 64295 [details]
Scripts & Windows

How is this?
(Assignee)

Comment 15

16 years ago
Created attachment 64359 [details] [diff] [review]
patch

Screenshot at: http://nexgenmedia.net/mozilla/pref-scripts.png (matches
jglick's picture)
(Assignee)

Updated

16 years ago
Attachment #64359 - Flags: needs-work+
(Assignee)

Comment 16

16 years ago
Created attachment 64677 [details] [diff] [review]
better patch

new patch
Attachment #64359 - Attachment is obsolete: true
could I see a diff -wu just for clarity?
(Assignee)

Comment 18

16 years ago
Created attachment 64837 [details] [diff] [review]
diff -wu

diff -wu version
(Assignee)

Comment 19

16 years ago
Comment on attachment 64677 [details] [diff] [review]
better patch

I got a newer version without the evil overlay hack
Attachment #64677 - Flags: needs-work+
(Assignee)

Comment 20

16 years ago
Created attachment 64866 [details] [diff] [review]
newest patch

new patch has no evil overlay hack. If you need a diff -wu, shout at me
Attachment #64677 - Attachment is obsolete: true
Attachment #64837 - Attachment is obsolete: true
(Assignee)

Comment 21

16 years ago
Created attachment 65070 [details] [diff] [review]
new patch that applies

previous patch wouldn't apply correctly, this should fix it
Attachment #64866 - Attachment is obsolete: true
(Assignee)

Comment 22

16 years ago
Created attachment 65079 [details] [diff] [review]
really appliable patch

Sorry about this, something was wrong in my local version of a file that caused
wierd diff issues
Attachment #65070 - Attachment is obsolete: true
(Assignee)

Comment 23

16 years ago
Created attachment 65091 [details] [diff] [review]
really really appliable patch

Added an newline to make it apply, thanks to db48x for figuring that out. No
idea what is wrong with 'diff' here
Attachment #65079 - Attachment is obsolete: true
Comment on attachment 65091 [details] [diff] [review]
really really appliable patch

and on that note, r=db48x
Attachment #65091 - Flags: review+
(Assignee)

Comment 25

16 years ago
cc: alecf for superreview
Status: NEW → ASSIGNED

Comment 26

16 years ago
ok, I'm shouting at you for a -wu version... :)
(Assignee)

Comment 27

16 years ago
Created attachment 65106 [details] [diff] [review]
diff -wu version

diff -wu it is

Comment 28

16 years ago
Comment on attachment 65091 [details] [diff] [review]
really really appliable patch

seems reasonable. sr=alecf
Attachment #65091 - Flags: superreview+

Comment 29

16 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
verified fixed using 2002.01.29.1x comm verif bits on linux rh7.2, win2k and mac
10.1.2.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.