Closed
Bug 1175215
Opened 10 years ago
Closed 8 years ago
Move the Exclusion Profile editor to a new view, rather than a drop-down panel
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
Details
The exclusion profiles would be easier to edit if the editor was full-page. This would open up to other ui enhancements like larger selection windows, etc.
Assignee | ||
Comment 1•10 years ago
|
||
Some relevant files to this work:
The angular controller for this tab:
https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/sheriff.js#L6-5
The model for the exclusion_profiles:
https://github.com/mozilla/treeherder/blob/master/ui/js/models/exclusion_profile.js#L7-6
The HTML for the current panel:
https://github.com/mozilla/treeherder/blob/master/ui/partials/main/thSheriffPanel.html#L1-0
The Sheriff button:
https://github.com/mozilla/treeherder/blob/master/ui/partials/main/thGlobalTopNavPanel.html#L16-16
Updated•10 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•8 years ago
|
||
This was fixed here in these commits.
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/de9868d613f4b02371cecf8b8b4c102583ddfe9f
Bug 1266116 - Use wildcard in grunt usemin instead of listing file
https://github.com/mozilla/treeherder/commit/fb435816b06ba4a77a897a82a049de3747cb2cc8
Bug 1266116 - Add the Admin page: Full-page exclusion editor
This moves the Sheriff panel out to a full-page app. The functionality
is basically the same, however. Much of the logic and HTML were just
copied from the Sheriff panel.
This also introduces ReactJS to the repo. This was used to speed up
the rendering of the reference data lists in the Exclusions detail
editor. The ``reactselect`` component is defined as normal JavaScript.
We decided not to introduce using JSX at this time.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cdawson
You need to log in
before you can comment on or make changes to this bug.
Description
•