1175219 - Strange error message when urlopen request for crash reporter symbols fails: "AttributeError: addinfourl instance has no attribute '__exit__'"

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Markus Stange [:mstange]]

as observed on http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f4c35b8e21d8/try-win32/try_xp-ix_test-chromez-bm111-tests1-windows-build216.txt.gz :

> 17:30:24     INFO -  Mon Jun 15 17:30:23 2015 MainThread         Retrieving symbol zip from https://queue.taskcluster.net/v1/task/lY3aydKoSlazObCfRmNJYA/artifacts/public/build/firefox-41.0a1.en-US.win32.crashreporter-symbols.zip...
> 17:30:24    ERROR -  Traceback (most recent call last):
> 17:30:24     INFO -    File "C:\slave\test\build\venv\Scripts\talos-script.py", line 9, in <module>
> 17:30:24     INFO -      load_entry_point('talos==0.0', 'console_scripts', 'talos')()
> 17:30:24     INFO -    File "C:\slave\test\build\venv\lib\site-packages\talos\run_tests.py", line 336, in main
> 17:30:24     INFO -      sys.exit(run_tests(parser))
> 17:30:24     INFO -    File "C:\slave\test\build\venv\lib\site-packages\talos\run_tests.py", line 267, in run_tests
> 17:30:24     INFO -      talos_results.add(mytest.runTest(browser_config, test))
> 17:30:24     INFO -    File "C:\slave\test\build\venv\lib\site-packages\talos\ttest.py", line 297, in runTest
> 17:30:24     INFO -      return self._runTest(browser_config, test_config)
> 17:30:24     INFO -    File "C:\slave\test\build\venv\lib\site-packages\talos\ttest.py", line 655, in _runTest
> 17:30:24     INFO -      browser_config['symbols_path']
> 17:30:24     INFO -    File "C:\slave\test\build\venv\lib\site-packages\talos\profiler\symbolication.py", line 136, in integrate_symbol_zip_from_url
> 17:30:24     INFO -      with urllib2.urlopen(symbol_zip_url, None, 30) as io:
> 17:30:24     INFO -  AttributeError: addinfourl instance has no attribute '__exit__'
> 17:30:24    ERROR - Return code: 1
> 17:30:24  WARNING - setting return code to 1
> 17:30:24    ERROR - # TBPL WARNING # 

Taskcluster is down at the moment. I've never seen this error message before, so I think it's only shown when the request fails.

Googling for the error message leads me to believe that urlopen shouldn't be used together with "with" unless you're using python 3.

Comment 1

[Markus Stange [:mstange]]

Attachment: patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8623176 [details] [diff] [review]
patch

Review of attachment 8623176 [details] [diff] [review]:
-----------------------------------------------------------------

this looks nice

Comment 3

[Mason Chang [Inactive] [:mchang]]

Can we land this? The error is still happening: 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e739add6d23

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/39db01f6dabb

Comment 5

[Markus Stange [:mstange]]

Thanks Joel.

I don't really expect this fix to fix Mason's problem, though, but you never know.

Comment 6

[Julien Pagès (:parkouss)]

Should'nt we close this bug ? I suppose that the landed patch fixed the issue here.

Comment 7

[Mason Chang [Inactive] [:mchang]]

This indeed fixed the talos profiling issue on try. Thanks!