1175421 - [Contacts][NGA] Extract 'match' and 'showDuplicateContacts' from service_extensions.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jorge Prudencio [:jorgep]]

To separate FB functionality from other functionalities, we are going to extract 'match' and 'showDuplicateContacts' from service_extensions.js to another class. These functions don't need FB to work.

Comment 1

[Jorge Prudencio [:jorgep]]

Attachment: 30622.html

Comment 2

[Maria Angeles Oteo (:oteo)]

As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8623549 [details]
30622.html

Hi Jorge,

looking good to me, just one comment on gh, related to when to load the js file. Right now is loaded always, and we could avoid to load it just for the list. The moment we go to detail or form then we could show it, wdyt?

Comment 4

[Jorge Prudencio [:jorgep]]

Hello Francisco,

I've already done the changes :-)

Ready to land!

Thanks

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Thanks for the work Jorge,

landed:

https://github.com/mozilla-b2g/gaia/commit/88a85959a2034d1f073e8e5601254c159f35448f