1175434 - Quick search" bar overlaps with "Find in page" bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-06-17-08-22-31.png

Steps to reproduce:
1. Go to a webpage
2. Go to Menu -> Find in Page
3. Open a new tab and type some letters in the URL Bar


Expected results:
- The two bars should not overlap.

Actual results:
- "Quick search" bar overlaps with "Find in page" bar 
- Please see attached screenshot

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Besides any other layout fixes that should be done here, we should probably close/hide the FindBar when the BrowserSearch UI is displayed.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Besides any other layout fixes that should be done here, we should probably
> close/hide the FindBar when the BrowserSearch UI is displayed.

I think the HomePager is preferable.

Comment 3

[:Margaret Leibovic]

Mike or Sebastian, one of you want to take this?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Margaret Leibovic from comment #3)
> Mike or Sebastian, one of you want to take this?

Yep!

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: UI regression

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1175434 - Hide "Find in page" bar when browser search UI is displayed. r=mcomella

Bug 1175434 - Hide "Find in page" bar when browser search UI is displayed. r=mcomella

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b764123cffad

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF41 as it's a UI regression. Adding the keyword "regression".

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8624650 [details]
MozReview Request: Bug 1175434 - Hide "Find in page" bar when browser search UI is displayed. r=mcomella

https://reviewboard.mozilla.org/r/11719/#review10411

Ship It!

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/5eccb63fdec6

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5eccb63fdec6

Comment 12

[Flaviu Cos]

Verified as fixed in builds:
- 42.0a1 2015-06-29;
- 41.0a2 2015-06-29;
Device: Motorola Razr (Android 4.4.4).