Closed Bug 1175451 Opened 5 years ago Closed 5 years ago

Change "Added to list" super toast to "Page added to your Reading List"

Categories

(Firefox for Android Graveyard :: Reading List, defect)

41 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox41 affected, firefox42 verified)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox41 --- affected
firefox42 --- verified

People

(Reporter: TeoVermesan, Assigned: Margaret)

Details

Attachments

(2 files)

Steps to reproduce:
1. Go to news.google.com and choose an article
2. Open menu and tap the reading list icon

Actual results:
- "Added to list | SWITCH" notification is displayed

Expected results:
- "Page added to your Reading List | SWITCH" notification should be displayed

Note;
- Long-tapping on the reader view icon from the URL Bar will display "Added to list | SWITCH" toast notification.
- Long-tapping once again on the reader icon from the URL Bar will display "Page already in your Reading List | SWITCH" toast notification
- Add to reading list notification should be consistent in every place.
I think we probably chose "Added to list" to avoid having such a long message in a button toast. antlam, what do you think we should do here?
Flags: needinfo?(alam)
We originally had thought about the longer, "Page added to your Reading List" but that was way too long and did not localize well.

"Already added to Reading List" was also too long, so we went with the more generic, "Added to list". I would be ok with "Added to Reading List" as a way to be more explicit about which list?
Flags: needinfo?(alam)
(In reply to Anthony Lam (:antlam) from comment #2)
> We originally had thought about the longer, "Page added to your Reading
> List" but that was way too long and did not localize well.
> 
> "Already added to Reading List" was also too long, so we went with the more
> generic, "Added to list". I would be ok with "Added to Reading List" as a
> way to be more explicit about which list?

Yeah, I think "Added to Reading List" would be a good improvement, since "Reading List" is how we talk about the feature throughout the product.
Assignee: nobody → margaret.leibovic
Bug 1175451 - Change "Added to list" super toast to "Page added to Reading List". r=nalexander
Attachment #8627409 - Flags: review?(nalexander)
Attached image screenshot
I'm trying to charge a low-res device to test there as well, but it looks like we have plenty of room to spare here, at least on the higher res devices.
Comment on attachment 8627409 [details]
MozReview Request: Bug 1175451 - Change "Added to list" super toast to "Page added to Reading List". r=nalexander

https://reviewboard.mozilla.org/r/12229/#review10715

Ship It!
Attachment #8627409 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/81c361d399a0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Target Milestone: Firefox 41 → Firefox 42
'Added to Reading List | SWITCH' super toast is now displayed.

Verified as fixed in build 42.0a1 2015-07-02;
Device: Asus Transformer Pad (Android 4.2.1).
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.