1175451 - Change "Added to list" super toast to "Page added to your Reading List"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reading List, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Go to news.google.com and choose an article
2. Open menu and tap the reading list icon

Actual results:
- "Added to list | SWITCH" notification is displayed

Expected results:
- "Page added to your Reading List | SWITCH" notification should be displayed

Note;
- Long-tapping on the reader view icon from the URL Bar will display "Added to list | SWITCH" toast notification.
- Long-tapping once again on the reader icon from the URL Bar will display "Page already in your Reading List | SWITCH" toast notification
- Add to reading list notification should be consistent in every place.

Comment 1

[:Margaret Leibovic]

I think we probably chose "Added to list" to avoid having such a long message in a button toast. antlam, what do you think we should do here?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

We originally had thought about the longer, "Page added to your Reading List" but that was way too long and did not localize well.

"Already added to Reading List" was also too long, so we went with the more generic, "Added to list". I would be ok with "Added to Reading List" as a way to be more explicit about which list?

Comment 3

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #2)
> We originally had thought about the longer, "Page added to your Reading
> List" but that was way too long and did not localize well.
> 
> "Already added to Reading List" was also too long, so we went with the more
> generic, "Added to list". I would be ok with "Added to Reading List" as a
> way to be more explicit about which list?

Yeah, I think "Added to Reading List" would be a good improvement, since "Reading List" is how we talk about the feature throughout the product.

Comment 4

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1175451 - Change "Added to list" super toast to "Page added to Reading List". r=nalexander

Bug 1175451 - Change "Added to list" super toast to "Page added to Reading List". r=nalexander

Comment 5

[:Margaret Leibovic]

Attachment: screenshot

I'm trying to charge a low-res device to test there as well, but it looks like we have plenty of room to spare here, at least on the higher res devices.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8627409 [details]
MozReview Request: Bug 1175451 - Change "Added to list" super toast to "Page added to Reading List". r=nalexander

https://reviewboard.mozilla.org/r/12229/#review10715

Ship It!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/81c361d399a0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81c361d399a0

Comment 9

[Flaviu Cos]

'Added to Reading List | SWITCH' super toast is now displayed.

Verified as fixed in build 42.0a1 2015-07-02;
Device: Asus Transformer Pad (Android 4.2.1).