Closed Bug 1175509 Opened 7 years ago Closed 9 months ago

convert nsHTMLScrollFrame::ScrolledContentDependsOnHeight to work with logical coordinates

Categories

(Core :: Layout: Scrolling and Overflow, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: jfkthame, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This should become ScrolledContentDependsOnBSize (a transition that is implicitly happening already, as the NS_FRAME_CONTAINS_RELATIVE_HEIGHT flag is being used in relation to block-size rather than height in an increasing number of places); the caller (nsHTMLScrollFrame::TryLayout) will need to be adapted accordingly. Probably it should exchange the priority with which it considers vertical vs horizontal scrollbars when working in vertical mode.
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED

This patch potentially changes the behavior when the scrolled frame is in
vertical writing-mode, but it should be the correct way to handle the scrollbar
change.

Depends on D130710

Component: Layout → Layout: Scrolling and Overflow
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b3fac7943816
Part 1 - Rename ScrolledContentDependsOnHeight to ScrolledContentDependsOnBSize. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3dcd29df439b
Part 2 - Make TryLayout correctly consider ScrolledContentDependsOnBSize in vertical writing-mode. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.