1175509 - convert nsHTMLScrollFrame::ScrolledContentDependsOnHeight to work with logical coordinates

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Jonathan Kew [:jfkthame]]

This should become ScrolledContentDependsOnBSize (a transition that is implicitly happening already, as the NS_FRAME_CONTAINS_RELATIVE_HEIGHT flag is being used in relation to block-size rather than height in an increasing number of places); the caller (nsHTMLScrollFrame::TryLayout) will need to be adapted accordingly. Probably it should exchange the priority with which it considers vertical vs horizontal scrollbars when working in vertical mode.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1175509 Part 1 - Rename ScrolledContentDependsOnHeight to ScrolledContentDependsOnBSize. r?jfkthame

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1175509 Part 2 - Make TryLayout correctly consider ScrolledContentDependsOnBSize in vertical writing-mode. r?jfkthame

This patch potentially changes the behavior when the scrolled frame is in
vertical writing-mode, but it should be the correct way to handle the scrollbar
change.

Depends on D130710

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3fac7943816
Part 1 - Rename ScrolledContentDependsOnHeight to ScrolledContentDependsOnBSize. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3dcd29df439b
Part 2 - Make TryLayout correctly consider ScrolledContentDependsOnBSize in vertical writing-mode. r=emilio

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b3fac7943816
https://hg.mozilla.org/mozilla-central/rev/3dcd29df439b