Closed Bug 1175639 Opened 9 years ago Closed 9 years ago

Regression: Reader Mode button visible even when reader mode is unavailable for page

Categories

(Firefox for iOS :: Reader View, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: fluffyemily, Assigned: fluffyemily)

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
Introduced during the URLBar/BrowserLocationView rewrite, if the webpage being shown does not have ReaderMode available, the reader mode button is still visible, but does nothing when pressed. The ReaderMode button should not appear unless ReaderMode is available for the page
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request
A little one fixing a bug I introduced.
Attachment #8623833 - Flags: review?(sarentz)
Comment on attachment 8623833 [details] [review] Pull request LGTM
Attachment #8623833 - Flags: review?(sarentz) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: