1175657 - The customize panel is on the wrong side of the screen in RTL mode

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

With bug 1168589 landed, in RTL mode, the panel anchors to the wrong side of the screen.

STR:

1) Ensure you have a build with the patch from bug 1168589 in it.
2) Add a new string in about:config with the name intl.uidirection.en-US set to rtl
3) Open a new tab
4) Click on the gear icon on the left-side of the screen

ER:

The panel that opens should be anchored to the gear icon.

AR:

The panel anchors to the right side of the screen, as it would normally do in LTR mode.

Comment 1

[Ursula Sarracini (:ursula)]

Attachment: The customize panel is on the wrong side of the screen in RTL mode

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8623863 [details] [diff] [review]
The customize panel is on the wrong side of the screen in RTL mode

Review of attachment 8623863 [details] [diff] [review]:
-----------------------------------------------------------------

Glad to know it's pretty straight-forward.

::: browser/base/content/newtab/newTab.css
@@ +520,5 @@
>    top: -6px;
>    right: 15px;
>  }
>  
> +#newtab-customize-panel-anchor:-moz-locale-dir(rtl) {

This looks very similar to the other rule you've added.

Could you please combine the two rules, like this:

#newtab-customize-panel:-moz-locale-dir(rtl),
#newtab-custmoize-panel-anchor:-moz-locale-dir(rtl) {
  left: 15px;
  right: auto;
}

#newtab-customize-panel:-moz-locale-dir(rtl) {
  transform-origin: 40px top 20px;
}

Comment 3

[Ursula Sarracini (:ursula)]

Attachment: The customize panel is on the wrong side of the screen in RTL mode

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8623871 [details] [diff] [review]
The customize panel is on the wrong side of the screen in RTL mode

Looks great!

I'll wait for the dependency to land on central before landing this.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b6340f3f7bf9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b6340f3f7bf9

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

Confirming the fix on latest 41.0a2, build ID: 20150802004005.