The customize panel is on the wrong side of the screen in RTL mode

VERIFIED FIXED in Firefox 41

Status

()

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: mconley, Assigned: ursula)

Tracking

unspecified
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox41 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
With bug 1168589 landed, in RTL mode, the panel anchors to the wrong side of the screen.

STR:

1) Ensure you have a build with the patch from bug 1168589 in it.
2) Add a new string in about:config with the name intl.uidirection.en-US set to rtl
3) Open a new tab
4) Click on the gear icon on the left-side of the screen

ER:

The panel that opens should be anchored to the gear icon.

AR:

The panel anchors to the right side of the screen, as it would normally do in LTR mode.
(Assignee)

Comment 1

3 years ago
Created attachment 8623863 [details] [diff] [review]
The customize panel is on the wrong side of the screen in RTL mode
(Reporter)

Updated

3 years ago
Assignee: nobody → ursulasarracini
(Reporter)

Updated

3 years ago
Assignee: ursulasarracini → nobody
(Assignee)

Updated

3 years ago
Assignee: nobody → ursulasarracini
(Assignee)

Updated

3 years ago
Attachment #8623863 - Flags: review?(mconley)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8623863 [details] [diff] [review]
The customize panel is on the wrong side of the screen in RTL mode

Review of attachment 8623863 [details] [diff] [review]:
-----------------------------------------------------------------

Glad to know it's pretty straight-forward.

::: browser/base/content/newtab/newTab.css
@@ +520,5 @@
>    top: -6px;
>    right: 15px;
>  }
>  
> +#newtab-customize-panel-anchor:-moz-locale-dir(rtl) {

This looks very similar to the other rule you've added.

Could you please combine the two rules, like this:

#newtab-customize-panel:-moz-locale-dir(rtl),
#newtab-custmoize-panel-anchor:-moz-locale-dir(rtl) {
  left: 15px;
  right: auto;
}

#newtab-customize-panel:-moz-locale-dir(rtl) {
  transform-origin: 40px top 20px;
}
Attachment #8623863 - Flags: review?(mconley) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8623871 [details] [diff] [review]
The customize panel is on the wrong side of the screen in RTL mode
(Assignee)

Updated

3 years ago
Attachment #8623863 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8623871 - Flags: review?(mconley)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8623871 [details] [diff] [review]
The customize panel is on the wrong side of the screen in RTL mode

Looks great!

I'll wait for the dependency to land on central before landing this.
Attachment #8623871 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/b6340f3f7bf9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Confirming the fix on latest 41.0a2, build ID: 20150802004005.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.