1175706 - Listen for logging pref changes

Status: RESOLVED WONTFIX

(Instantbird Graveyard :: Preferences, defect)

Description

[arlolra]

Attachment: listen.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.124 Safari/537.36

Steps to reproduce:

Turned off logging during a conversation.


Actual results:

Kept logging the conversation.


Expected results:

Didn't.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8623896 [details] [diff] [review]
listen.patch

Review of attachment 8623896 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Please do not support immediately responding to a change in the logging format pref. My first instinct is that it seems like it could lead to weird issues with the filename and would require more tests. In any case, we will probably remove txt log support sooner or later.

Also, please add a couple of small tests for this to the existing logger tests (flipping the pref with a conv open, doing it multiple times, etc)

Comment 2

[arlolra]

Attachment: listen.patch from comment 1

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8624270 [details] [diff] [review]
listen.patch from comment 1

Review of attachment 8624270 [details] [diff] [review]:
-----------------------------------------------------------------

I should have noticed this before, but with this patch, if you disable and re-enable the pref, the log header will be appended again to the existing log file.
I think this bug should wait for split log files to land, which will allow us to somehow start a new file for this case.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8624270 [details] [diff] [review]
listen.patch from comment 1

I don't really have the context for this anymore, life happened. Please re-request review if you'd like to resurrect this.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.