Closed Bug 1175706 Opened 5 years ago Closed Last year

Listen for logging pref changes

Categories

(Instantbird :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: arlolra, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch listen.patch (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.124 Safari/537.36

Steps to reproduce:

Turned off logging during a conversation.


Actual results:

Kept logging the conversation.


Expected results:

Didn't.
Attachment #8623896 - Attachment is patch: true
Attachment #8623896 - Attachment mime type: text/x-patch → text/plain
Attachment #8623896 - Flags: review?(nhnt11)
Attachment #8623896 - Flags: review?(aleth)
Comment on attachment 8623896 [details] [diff] [review]
listen.patch

Review of attachment 8623896 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Please do not support immediately responding to a change in the logging format pref. My first instinct is that it seems like it could lead to weird issues with the filename and would require more tests. In any case, we will probably remove txt log support sooner or later.

Also, please add a couple of small tests for this to the existing logger tests (flipping the pref with a conv open, doing it multiple times, etc)
Attachment #8623896 - Flags: review?(nhnt11) → feedback+
Attachment #8623896 - Attachment is obsolete: true
Attachment #8623896 - Flags: review?(aleth)
Attachment #8624270 - Flags: review?(nhnt11)
Comment on attachment 8624270 [details] [diff] [review]
listen.patch from comment 1

Review of attachment 8624270 [details] [diff] [review]:
-----------------------------------------------------------------

I should have noticed this before, but with this patch, if you disable and re-enable the pref, the log header will be appended again to the existing log file.
I think this bug should wait for split log files to land, which will allow us to somehow start a new file for this case.
Attachment #8624270 - Flags: review?(nhnt11) → review-
Depends on: 1025522
Attachment #8624270 - Flags: review- → review?
Attachment #8624270 - Flags: review?
Attachment #8624270 - Flags: review?(nhnt11)
Comment on attachment 8624270 [details] [diff] [review]
listen.patch from comment 1

I don't really have the context for this anymore, life happened. Please re-request review if you'd like to resurrect this.
Attachment #8624270 - Flags: review?(nhnt11)
On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.
Status: UNCONFIRMED → RESOLVED
Closed: Last year
Resolution: --- → WONTFIX
On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.
You need to log in before you can comment on or make changes to this bug.