117573 - Reduce calls to addref on mailnews urls upon folder discovery

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID:  Windows 2000, latest trunk running under Quantify.

Summary: Optimize/reduce calls to nsMsgFolder::AddRef

Steps to Reproduce:

1.  On an IMAP account, bring up mozilla.exe -mail under Quantify.
2.  Exit Mozilla.
3.  Sort by function in Quantify.

Expected Results:

I'm not totally sure if my bug is even valid (it's my 1st time using Quantify 
to attempt to profile startup performance).  Please feel free to invalidate as 
necessary, thanks.

Actual Results:

The global function nsMsgFolder::AddRef takes 98.3% (2,809 calls) of the time 
we spend in nsMsgMailNewsUrl:AddRef (which of its own, has 2,858 calls using 
the above scenario).

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot of Quantify

I also have the logs of my Quantify startup profile in .qfy and .txt if anybody
wants them.

Comment 2

[David :Bienvenu]

I'm not sure what this has to do with the mail database - the db doesn't addref
the folder very often. Looks to me like this would be the folder pane, if anything.

Comment 3

[David :Bienvenu]

but these functions also take up 0.0% of startup time, so they're not that
interesting. How many imap folders do you have? Also, the stack seems suspicious
because nsMsgFolder::AddRef is not a caller of nsMsgMailNewsUrl::AddRef, as near
as I can tell.

Comment 4

[David :Bienvenu]

Are you downloading lots of headers in your test case? I basically see calls to
addref on the mailnews url whenever we discover a folder (which I can fix), when
we download header lines, and when we display progress/status. W/O downloading
lots of headers, I don't think we get nearly that many calls to
nsMsgMailNewsUrl::AddRef.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

There were 12 messages in my IMAP Inbox when I ran this testcase, but I didn't do 
a GetMsgs, so 12 should be it.  It might be helpful to morph this bug from your 
comment:


I basically see calls to
addref on the mailnews url whenever we discover a folder (which I can fix)

Comment 6

[David :Bienvenu]

It only matters how many headers are in your inbox if you had to download those
headers during the quantified session, e.g., if the .msf file was out of date.
Do you remember if it did?

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot of Quantify, this time I cancelled the Mail Server Password Required dialog

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

To answer your question, David, no I didn't download any new headers.  I 
believe the .msf file was correct and complete.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

David, Seth looked at my Quantify run last night, and agreed that the profile
(at least for that function) seemed bogus.  I'll let you adjust this bug as you
see fit now.  Sorry for the noise.

Comment 10

[scottputterman]

Moving to future.  It sounds like this might be a wontfix based on comments, so
if it is, please update the bug.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Changing summary to reflect the only valid portion of this bug.

Comment 12

[David :Bienvenu]

I checked in some fixes for this, but it sounds like the general profile seems
bogus.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

It was, thanks.