Closed Bug 1175741 Opened 5 years ago Closed 4 years ago

Unsigned add-on warning appears in about:addons for OpenH264 video codec

Categories

(Firefox for Android :: Add-on Manager, defect)

35 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox41 --- verified
firefox42 --- fixed
fennec 41+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

The OpenH264 video codec is styled as an add-on, not a plugin, and one consequence of this is that is that the unsigned add-on warning will appear under it in the add-ons manager because it doesn't have the right signed state.

To fix this, I think we should just have a separate plugin style that hides this signed state UI.

(This won't be an issue until bug 1170841 lands.)
Sounds like a good interim solution. 

But do we plan on having more plug-ins in the future? We may find that we have to communicate the difference to the average user. Maybe we could just create plug-in specific UI as well.
Assignee: nobody → margaret.leibovic
tracking-fennec: --- → ?
Turns out the problem here is actually a bug with my CSS. Because we set the "isUnsigned" attribute on the detail item by pulling the attribute value from the list item attribute, we're actually setting it to the string "false" rather than the boolean value:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.js#315

This makes this attribute always truthy, so this CSS selector doesn't work as expected.
Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche
Attachment #8627444 - Flags: review?(liuche)
Attachment #8627444 - Flags: review?(liuche) → review+
Comment on attachment 8627444 [details]
MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

https://reviewboard.mozilla.org/r/12241/#review10815

Ship It!
Comment on attachment 8627444 [details]
MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

Approval Request Comment
[Feature/regressing bug #]: bug 1170841
[User impact if declined]: unsigned add-on warning will appear for all add-ons in about:addons
[Describe test coverage new/current, TreeHerder]: no automated tests, tested locally
[Risks and why]: low-risk, small CSS change
[String/UUID change made/needed]: none
Attachment #8627444 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/00ff94876fae
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
tracking-fennec: ? → 41+
Comment on attachment 8627444 [details]
MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

Approving for uplift to Aurora. Simple fix.
Attachment #8627444 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed on Firefox 41 Beta 1
You need to log in before you can comment on or make changes to this bug.