1175741 - Unsigned add-on warning appears in about:addons for OpenH264 video codec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[:Margaret Leibovic]

The OpenH264 video codec is styled as an add-on, not a plugin, and one consequence of this is that is that the unsigned add-on warning will appear under it in the add-ons manager because it doesn't have the right signed state.

To fix this, I think we should just have a separate plugin style that hides this signed state UI.

(This won't be an issue until bug 1170841 lands.)

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Sounds like a good interim solution. 

But do we plan on having more plug-ins in the future? We may find that we have to communicate the difference to the average user. Maybe we could just create plug-in specific UI as well.

Comment 2

[:Margaret Leibovic]

Turns out the problem here is actually a bug with my CSS. Because we set the "isUnsigned" attribute on the detail item by pulling the attribute value from the list item attribute, we're actually setting it to the string "false" rather than the boolean value:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.js#315

This makes this attribute always truthy, so this CSS selector doesn't work as expected.

Comment 3

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8627444 [details]
MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

https://reviewboard.mozilla.org/r/12241/#review10815

Ship It!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/00ff94876fae

Comment 6

[:Margaret Leibovic]

Comment on attachment 8627444 [details]
MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

Approval Request Comment
[Feature/regressing bug #]: bug 1170841
[User impact if declined]: unsigned add-on warning will appear for all add-ons in about:addons
[Describe test coverage new/current, TreeHerder]: no automated tests, tested locally
[Risks and why]: low-risk, small CSS change
[String/UUID change made/needed]: none

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00ff94876fae

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8627444 [details]
MozReview Request: Bug 1175741 - Properly hide unsigned add-on warning in add-on manager. r=liuche

Approving for uplift to Aurora. Simple fix.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c73b2abc0b01

Comment 10

[u421692]

Verified as fixed on Firefox 41 Beta 1