Closed Bug 1175789 Opened 4 years ago Closed 4 years ago

underline position of vertical text should be adjusted in Gecko

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 2 open bugs, )

Details

(Keywords: intl)

Attachments

(1 file)

text-underline-position is still not enough stable.

We should adjust underline position of vertical text to left or right with the language information in Gecko (internally).
text-underline-position has not been stable yet. Therefore, we should set default underline position as right side of lines only in Japanese and Korean language (like IE does).
Attachment #8624094 - Flags: review?(dbaron)
Keywords: intl
OS: Unspecified → All
Hardware: Unspecified → All
Comment on attachment 8624094 [details] [diff] [review]
Draw underline as overline when it's in vertical writing mode and the language is Japanese or Korean

Given the default styles in css-text-decor-3, this seems reasonable to do for now.

Have you tested that the selection decoration painting works as you expect?

r=dbaron
Attachment #8624094 - Flags: review?(dbaron) → review+
(In reply to David Baron [:dbaron] ⏰UTC-7 (mostly busy, back June 29) from comment #2)
> Have you tested that the selection decoration painting works as you expect?

Sure. Thank you for your review!
https://hg.mozilla.org/mozilla-central/rev/5b2d133bace3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #6)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4ab7c22deeb

Oops, I used wrong entry of my bash history at qrefresh. So, this is for different bug.

Sorry for the spam.
You need to log in before you can comment on or make changes to this bug.