1175789 - underline position of vertical text should be adjusted in Gecko

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

text-underline-position is still not enough stable.

We should adjust underline position of vertical text to left or right with the language information in Gecko (internally).

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Draw underline as overline when it's in vertical writing mode and the language is Japanese or Korean

text-underline-position has not been stable yet. Therefore, we should set default underline position as right side of lines only in Japanese and Korean language (like IE does).

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8624094 [details] [diff] [review]
Draw underline as overline when it's in vertical writing mode and the language is Japanese or Korean

Given the default styles in css-text-decor-3, this seems reasonable to do for now.

Have you tested that the selection decoration painting works as you expect?

r=dbaron

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to David Baron [:dbaron] ⏰UTC-7 (mostly busy, back June 29) from comment #2)
> Have you tested that the selection decoration painting works as you expect?

Sure. Thank you for your review!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2d133bace3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b2d133bace3

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4ab7c22deeb

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #6)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4ab7c22deeb

Oops, I used wrong entry of my bash history at qrefresh. So, this is for different bug.

Sorry for the spam.