1175809 - [NFC] Unable to share URL via NFC when play video on full screen mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect, P1)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_1129.txt

[1.Description]:
[Flame v2.2 & v3.0][Nexus 5 v2.2 & v3.0][NFC]Device will jumpt to another page with only have address bar when you share the online playing video by NFC.
Found time:11:29
See attachment:1129.3gp and logcat_1129.txt

[2.Testing Steps]: 
1.Turn on the NFC in Settings.
2.Launch Browser on Device A.
3.Go to Youtube.com.
4.Select a video, and play it in full screen mode.
5.Put Device A and Device B back to back.

[3.Expected Result]: 
5.Device should display share page, and share the link successfully by NFC.

[4.Actual Result]: 
5.The page can't display share view. On both device A and B, it will jump to another page which is null with only an address bar.

[5.Reproduction build]: 
Device: Flame 2.2 version(Affected):
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.040422
Firmware Date          Wed Jun 17 04:04:34 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 version(Affected):
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.192003
Firmware Date          Wed Jun 17 19:20:14 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5_2.2 version(Affected):
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.042332
Firmware Date          Wed Jun 17 04:24:07 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5_3.0 version(Affected):
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.192258
Firmware Date          Wed Jun 17 19:23:17 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
On 2.2 version, the address bar locates at bottom. However on version 3.0, it locates at top, sometimes, the Flame playing the video, you can only hear the voice after you remove the device B.

Comment 1

[Lance（leave from Mozilla）]

Attachment: 1129.3GP

Comment 2

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

Bad user experience.
Suggest to fix on the latest branch.

Comment 3

[Mahendra Potharaju [:mahe]]

Wilfred, Can you please confirm if this is part of 2.5 scope and should be +ed ?

Thanks

Comment 4

[Wilfred Mathanaraj [:WDM]]

let NFC/sysfe team triage and review if this is needed. I dont think there is anything being fixed specicialy for this bug.

Comment 5

[Gregor Wagner [:gwagner]]

The systemsfe team hasn't implemented nfc sharing. I can see Kens name on many nfc related sharing bugs. He knows this topic much better than me :)

Comment 6

[Sandip Kamat]

Sharing URL by NFC has been supported since past releases. This looks like a regression or a bug. Recommend to fix for 2.5.

Comment 7

[Mahendra Potharaju [:mahe]]

Blocks 2.5. regression defect

Comment 8

[Ken Chang[:kenkai]]

Hi Alison,
  Can you please check if this is a regression?

Comment 9

[Alison Shiue]

I tried with 2.0 and 2.1 build, both of them would stay at current full screen instead of jump to another null page, but also cannot be shared via NFC.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

It looks like Shrinking UI has problems when playing video in Browser.
Should be a gaia bug.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ni? for Tim to check ShrinkingUI when running full screen mode in Browser.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Is it possible to identify the regressed bug between 2.1 and 2.2?

Comment 13

[Shally Li（leave from Mozilla）]

The oldest build in b2g-inbound / mozilla-inbound is 20150609153752 / 20150609172153, which is later than the first broken build & last working build, so I try to do the regression in Nightly builds.


Nightly Regression Window:

Last Working Environmental Variables:
Build ID               20141031040201
Gaia Revision          8ae6598f3ab7b0c34ac42a73083ddb74266affba
Gaia Date              2014-10-30 17:56:06
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e0b505a37b1c
Gecko Version          36.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20141030.192246
Firmware Date          Thu Oct 30 19:22:57 EDT 2014
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Build ID               20141031160202
Gaia Revision          5964f1339f37e7595aff7de7512b8529bc640b76
Gaia Date              2014-10-31 17:13:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b695d9575654
Gecko Version          36.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20141030.192246
Firmware Date          Thu Oct 30 19:22:57 EDT 2014
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia Revision          5964f1339f37e7595aff7de7512b8529bc640b76
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e0b505a37b1c

First Broken Gecko & Last Working Gaia - issue DOES NOT repro
Gaia Revision          8ae6598f3ab7b0c34ac42a73083ddb74266affba
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b695d9575654


Gecko pushlog:
https://github.com/mozilla-b2g/gaia/compare/8ae6598f3ab7b0c34ac42a73083ddb74266affba...5964f1339f37e7595aff7de7512b8529bc640b76


----------------------------------------------------------------------------------------------
Note:
On Flame v2.1, in step 5, device will have vibration but not show "Swipe to share" animation on fullscreen, and the video is playing normally.

Comment 14

[Ken Chang[:kenkai]]

Greg, please help this bug.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

It would be better if we can have a offline discussion since I have some questions want to ask.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

Bisecting result:

1. Shareable when not fullscreen; NOT shareable when fullscreen
----
Build ID               20141031040201
Gaia Revision          8ae6598f3ab7b0c34ac42a73083ddb74266affba

2. NFC was **BROKEN**: device will not response no matter with shrinking UI or vibration
----
commit caebca410102c8fc8b0cce08af584e1ef391eac9
Date:   Fri Oct 31 08:31:59 2014 +0100

3. Fullscreen sharing was broken: could normally share content without fullscreen; with fullscreen it would become like this: http://imgur.com/26lm2HN
----
commit 396035af948d3e9c601f0a0ddac583f6cf1d9750
Date:   Fri Oct 31 10:53:15 2014 +0800


4. Worked well: block fullscreen sharing while remaining shareable when not in fullscreen mode
----
commit c544e4eb66d3ee43f0484ed30a7637586e03ea52
Date:   Thu Oct 30 16:17:30 2014 -0700


5. Worked well: block fullscreen sharing while remaining shareable when not in fullscreen mode
----
commit a07994714f0552f89801d6097982308d8b0a1ee1
Date:   Thu Oct 30 19:54:58 2014 -0400

6. Fullscreen sharing was broken: could normally share content without fullscreen; with fullscreen it would become like this: http://imgur.com/26lm2HN
----
commit aea7c7550345e5d2e11f880802a1b3eb0700aaae
Date:   Fri Oct 31 10:20:39 2014 +0800

7. Fullscreen sharing was broken: could normally share content without fullscreen; with fullscreen it would become like this: http://imgur.com/26lm2HN
----
commit db0f29c61dbbd6bd294c0c31a6ff49958352af74
Date:   Wed Oct 8 18:24:34 2014 +0800

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

To sum up, the first broken commit QA found is actually the point broke the whole NFC, not only the fullscreen sharing. So we may need another regression window from master to the real, first time it got broken, or we're hardly to make sure what caused the regression. From my bisecting it can only be traced to the strange 'blank page' sharing screen like the image (http://imgur.com/26lm2HN) shows is the first commit to make the shrinking UI as a standalone library:

    commit db0f29c61dbbd6bd294c0c31a6ff49958352af74
    Author: cctuan <[e-mail]>
    Date:   Wed Oct 8 18:24:34 2014 +0800
    
    Bug 1050164 - Investigate to implement standalone shrinking library


So I feel it's important to clear up the whole situation. If it's a regression older than that, we need to bypass the commit made NFC entirely broken. Otherwise, it may be broken since the commit, and we may need to find the window from that. Of course to bypass the totally breaking commit still need to be bypassed.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

And Ken, this is what I have now.

Comment 19

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1175809 > mozilla-b2g:master

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

Tim: since NFC has been changed a lot and browser is not an regular app, I want to ask if you think to patch it like this is good to you, or you have another better way to prevent sharing while it's in fullscreen?

And by the way, this sharing bug seems not a regression according to my latest bisecting result. So I can't restore things to repair that.

Comment 21

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patch looks good. I hope we could replace the shrink UI with something shared with other code path and consistent in the future, but that's up the to UX.

Comment 22

[Ken Chang[:kenkai]]

Alison, according to comment 17, can you please make sure this is a regression and get the regression window for us.

Comment 23

[Alison Shiue]

I don't think this is a regression issue because we cannot share URL via NFC when play video on full screen mode since v2.0.

Change title to match the main issue we need to resolve.

Comment 24

[Ken Chang[:kenkai]]

According to comment 17 and comment 23, this bug isn't a 2.5 blocker.

Comment 25

[Greg Weng [:snowmantw][:gweng][:λ]]

Try server is happy with the master patch:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=afb57e654e3d6f53399056833c1e43131fd6c893

And I will prepare a v2.2 patch. However, for v2.1 and v2.0, I don't have any idea if I should prepare it as well.

Comment 26

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1175809-2.2 > mozilla-b2g:v2.2

Comment 27

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8670610 [details] [review]
[gaia] snowmantw:bug1175809 > mozilla-b2g:master

According to Comment 21, I set the review. And I will fix the v2.2 patch for one failed unit test, and then raise the approval flag.

Comment 28

[Greg Weng [:snowmantw][:gweng][:λ]]

After been distracted by other bugs, I think it's better to land the master first. Since I need some time to fix the failure in 2.2.

Comment 29

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/a2731433466ac429ccacb91f1d9140047294aa47

Comment 30

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: Playing the youtube video on full screen mode, and sharing the URL via NFC, it doesn't show shrink UI and the video is playing normally, and only have a vibration when tapping two phones together.
See attachment: verified_Aries_v2.6.3gp
Reproduce rate: 0/10


Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151104150239
Gaia Revision          47da49f8206788d70d834c3a63d9245d50c89103
Gaia Date              2015-11-03 21:48:23
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6077f51254c69a1e14e1b61acba4af451bf1783e
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151104.182640
Firmware Date          Wed Nov  4 18:26:52 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151105105137
Gaia Revision          e68d693cb55fb5d8946498eb2bdb63f55116d38e
Gaia Date              2015-11-05 01:05:27
Gecko Revision         n/a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.rose.20151103.153542
Firmware Date          2015-11-03 Tuesday 15:36:03 CST
Bootloader             s1

Note:
On latest Flame v2.5, it still shows the shrink UI but unable to share via NFC, waiting for v2.5 uplift.

Comment 31

[Shally Li（leave from Mozilla）]

Attachment: verified_Aires_v2.6.3gp

Comment 32

[Greg Weng [:snowmantw][:gweng][:λ]]

I've found the patch is already in the v2.5 branch. Could you verify it again?

Comment 33

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Playing the youtube video on full screen mode, and sharing the URL via NFC, it doesn't show shrink UI and the video is playing normally, and only have a vibration when tapping two phones together.
See above attachment: "verified_Aries_v2.6.3gp"
Reproduce rate: 0/10


Device: Flame KK 2.5  512mb (Pass)
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1