1175833 - Buttons from conversation window are gone after adding/editing context

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the issue

Affected builds:
- Latest Nightly

Unaffected builds:
- Latest Aurora

Affected OS`s:
- Windows 7 64-bit
- Mac OS X 10.9.5
- Ubuntu 14.04 32-bit

STR:
1. Start Firefox
2. Visit https://www.mozilla.org/en-US/firefox/hello/
3. Click Hello icon
4. Start a conversation
5. From conversation window click 'Add some context'
6. Click Save

Alternative STR:
1. Start Firefox
2. Visit https://www.mozilla.org/en-US/firefox/hello/
3. Click Hello icon
4. Start a conversation with 'Let`s talk about' ticked
5. From conversation window enter context edit screen
6. Click Save

Expected results: Edit screen is closed and buttons are still visible.

Actual results: Edit screen is closed but buttons are gone from conversation window.

Notes:
- Gif showing the isssue attached.
- This is a regression that was introduced with bug 1170627.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Mike, it looks like this may have been caused by bug 1170627.

Comment 2

[Bogdan Maris, Desktop Test Engineering]

This issue does not reproduce anymore on latest Nightly 42.0a1, probably fixed in bug 1171940.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Bogdan, is this reproducible on firefox 40? Can you please update the status-firefox40 flag?

Comment 4

[Bogdan Maris, Desktop Test Engineering]

Yes, this is still reproducible on Firefox 40 across platforms.

Comment 5

[Mike de Boer [:mikedeboer]]

Liz, you were absolutely right, this IS caused by bug bug 1170627. You saved me an hour or two debugging! Thank you :-)

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: propagate editMode state change up the components tree

Simple fix, it turns out!

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8637184 [details] [diff] [review]
Patch v1: propagate editMode state change up the components tree

Looks good, r=Standard8

Comment 8

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae8527ff8823

Comment 9

[Mike de Boer [:mikedeboer]]

Comment on attachment 8637184 [details] [diff] [review]
Patch v1: propagate editMode state change up the components tree

Approval Request Comment
[Feature/regressing bug #]: bug 1170627
[User impact if declined]: User will not see the share action buttons in the invitation overlay when he/ she just saved the context attached to a conversation.
[Describe test coverage new/current, TreeHerder]: none, pushed to try (see comment 8). When green, we're good to go.
[Risks and why]: minor, 3-line change.
[String/UUID change made/needed]: n/a.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8637184 [details] [diff] [review]
Patch v1: propagate editMode state change up the components tree

From the try push it looks like we're gtg. Beta+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/32b26ad5041a

Comment 12

[Ada [:adalucinet]]

Verified fixed on 40.0b7 (Build ID: 20150723165742), across platforms [1].

[1] Windows 7 64-bit, Windows 10 32-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.4