1175835 - [Contacts][NGA] Extract 'sendEmailOrPick' from Contacts.js to Contacts_buttons.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jorge Prudencio [:jorgep]]

To reduce dependencies we are going to move sendEmailOrPick() from Contacts.js to Contacts_buttons.js. This function is only used in this class.

Comment 1

[Jorge Prudencio [:jorgep]]

Attachment: 30645.html

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8624085 [details]
30645.html

Hola Jorge!

Can you please rebase the patch, some changes enter and we need to update, but will be pretty simple.

Was also think that perhaps the |sendSMS| functionallity is the same, bust go just to the detail, taking into account that needs to load a file.

Thanks!

Comment 3

[Jorge Prudencio [:jorgep]]

Hello Francisco,

I have rebased the patch and I have researched about Contacts.sendSMS. This function is only used on contact_test.js tests. Should we delete this function and its tests?

Thanks!

Comment 4

[Maria Angeles Oteo (:oteo)]

As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8624085 [details]
30645.html

Hei Jorge,

sorry for the late response. Great, as we moved the sms sending to the shared component, we can get rid of:

https://github.com/jpruden92/gaia/blob/bug1175835-contacts/apps/communications/contacts/js/contacts.js#L400-L405 and the test case then.

Once that's ready, we are ready to merge :)

Thanks!

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8624085 [details]
30645.html

Great job Jorge! Seems that treeheder has some issue right now because all tests are in red. Could you relaunch it? Ensure treeherder is happy and we are ready to merge!

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/ba51728daf4de9922f8fbe46645a9d17ac20845d

Comment 8

[Carsten Book [:Tomcat]]

sorry had to revert this change for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2227864&repo=b2g-inbound

Comment 9

[Jorge Prudencio [:jorgep]]

Attachment: 30769.html

Comment 10

[Borja Salguero [:borjasalguero]]

Comment on attachment 8628158 [details]
30769.html

Great job Jorge! Waiting for treeherder to merge. Thanks!