To reduce dependencies we are going to move sendEmailOrPick() from Contacts.js to Contacts_buttons.js. This function is only used in this class.
Whiteboard: [NG Gaia Contacts]
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
Comment on attachment 8624085 [details] 30645.html Hola Jorge! Can you please rebase the patch, some changes enter and we need to update, but will be pretty simple. Was also think that perhaps the |sendSMS| functionallity is the same, bust go just to the detail, taking into account that needs to load a file. Thanks!
Hello Francisco, I have rebased the patch and I have researched about Contacts.sendSMS. This function is only used on contact_test.js tests. Should we delete this function and its tests? Thanks!
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Comment on attachment 8624085 [details] 30645.html Hei Jorge, sorry for the late response. Great, as we moved the sms sending to the shared component, we can get rid of: https://github.com/jpruden92/gaia/blob/bug1175835-contacts/apps/communications/contacts/js/contacts.js#L400-L405 and the test case then. Once that's ready, we are ready to merge :) Thanks!
Attachment #8624085 - Flags: review?(francisco) → review+
Comment on attachment 8624085 [details] 30645.html Great job Jorge! Seems that treeheder has some issue right now because all tests are in red. Could you relaunch it? Ensure treeherder is happy and we are ready to merge!
Attachment #8624085 - Flags: review?(borja.bugzilla) → review+
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: FxOS-S2 (10Jul) → FxOS-S1 (26Jun)
sorry had to revert this change for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2227864&repo=b2g-inbound
Status: RESOLVED → REOPENED
status-b2g-master: fixed → ---
Resolution: FIXED → ---
Target Milestone: FxOS-S1 (26Jun) → ---
Created attachment 8628158 [details] 30769.html
Comment on attachment 8628158 [details] 30769.html Great job Jorge! Waiting for treeherder to merge. Thanks!
Attachment #8628158 - Flags: review?(borja.bugzilla) → review+
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago → 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.