Closed
Bug 1175881
Opened 9 years ago
Closed 9 years ago
about:sync-log can't read files on OS X with e10s on and content process sandbox enabled
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 42
People
(Reporter: VarCat, Assigned: smichaud)
References
Details
Attachments
(1 file)
1.43 KB,
patch
|
areinald.bug
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Environment: FF 41 OS: Mac Os X 10.9.5 STR: 1. From about:config set services.sync.log.appender.file.logOnSuccess;true 2. Perform a sync. 3. Open one of the sync logs from about:sync-log Issue: The sync log is not displayed. Note: This bug is not reproducible with e10s disabled. This bug is not reproducible on Windows.
Reporter | ||
Updated•9 years ago
|
OS: Unspecified → Mac OS X
Hardware: Unspecified → All
Updated•9 years ago
|
tracking-e10s:
--- → ?
tracking-firefox41:
--- → +
Comment 1•9 years ago
|
||
Catalin, did you restart the browser after step 2? (iirc, it is required to make the config change stick)
Flags: needinfo?(catalin.varga)
Reporter | ||
Comment 2•9 years ago
|
||
I've tried again using the latest FF 42 Nightly and I've restarted the browser after step 2, the bug is still reproducible.
Flags: needinfo?(catalin.varga)
Comment 3•9 years ago
|
||
Can you try disabling the sandbox by setting security.sandbox.content.level to 0
Flags: needinfo?(smichaud)
Assignee | ||
Comment 4•9 years ago
|
||
I'll wait to respond until after Catalin answers comment #3.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(catalin.varga)
Reporter | ||
Comment 5•9 years ago
|
||
The bug is not reproducible when security.sandbox.content.level is set to 0 .
Flags: needinfo?(catalin.varga)
Assignee | ||
Comment 6•9 years ago
|
||
I have some more questions for you, Catalin: Does the bug happen with a clean profile (save for the change you made in your step 1)? Is the bug a recent regression? For example, does it also happen with FF 39, FF 40 beta and current Developer Edition nightlies (with clean profiles)? What directory is displayed in about:sync-log?
Flags: needinfo?(catalin.varga)
Assignee | ||
Comment 7•9 years ago
|
||
> Is the bug a recent regression? For example, does it also happen
> with FF 39, FF 40 beta and current Developer Edition nightlies (with
> clean profiles)?
Oops, sorry. I forgot this bug only happens in e10s mode, with the
content sandbox on. Do test in a current Developer Edition nightly,
though, with e10s on.
Comment 8•9 years ago
|
||
(In reply to Steven Michaud [:smichaud] from comment #6) > What directory is displayed in about:sync-log? sync logs are in the profile under: /Users/<user>/Library/Application Support/Firefox/Profiles/<salted profile>/weave/ Is that inaccessible when running sandboxed?
Assignee | ||
Comment 9•9 years ago
|
||
> Is that inaccessible when running sandboxed?
I don't believe so. But the relevant sandbox rules are very complex, and it's possible I'm reading them wrong.
In any case, I want to get as much information as I can before I start digging into this.
Reporter | ||
Comment 10•9 years ago
|
||
The bug is not reproducible on the latest FF 41 DevEdition with e10s enabled, the bug is reproducible using a new profile and the latest FF 42 Nightly build id:20150716030208 . The directory displayed under about:sync-log is: ///Users/svuser/Library/Application Support/Firefox/Profiles/7ybfeu28.73/weave/logs
Flags: needinfo?(catalin.varga)
Assignee | ||
Comment 11•9 years ago
|
||
I can reproduce this bug with yesterday's m-c nightly. (For some reason there isn't any Mac m-c nightly for today.) Oddly, the browser has no problem *writing* sync logs -- only reading them. I suspect they're written by the main/chrome process, but read by the content process. That isn't ideal -- all file access should (ultimately) be brokered through the chrome process. But in the meantime we do need to fix our content process sandbox rules. I wasn't able to reproduce this bug in yesterday's Developer Edition. The reason, it seems, is that the content process sandbox is either missing or off in the Developer Edition.
Assignee: nobody → smichaud
Flags: needinfo?(smichaud)
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Summary: [Mac OS X]Local files are not opened on Mac while e1os is enabled → [Mac OS X]Local files are not opened on Mac while e10s is enabled
Assignee | ||
Comment 12•9 years ago
|
||
This is a minimal patch -- it fixes just this bug as reported. I figure anything more ambitious should wait until we've proxied as much file access as we can through the main/chrome process.
Attachment #8639475 -
Flags: review?(areinald.bug)
Assignee | ||
Updated•9 years ago
|
Summary: [Mac OS X]Local files are not opened on Mac while e10s is enabled → about:sync-log can't read files on OS X with e10s on and content process sandbox enabled
Comment 13•9 years ago
|
||
Comment on attachment 8639475 [details] [diff] [review] Fix Review of attachment 8639475 [details] [diff] [review]: ----------------------------------------------------------------- Yes, that's the only way we can work around such issues for now. Looks fine to me.
Attachment #8639475 -
Flags: review?(areinald.bug) → review+
https://hg.mozilla.org/mozilla-central/rev/567e17d291f9
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8639475 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: bug 1083344 [User impact if declined]: Pretty bad UI bug [Describe test coverage new/current, TreeHerder]: Baked for a week on m-c [Risks and why]: Very low -- fix is very simple and precisely focused. [String/UUID change made/needed]: None
Attachment #8639475 -
Flags: approval-mozilla-aurora?
Comment on attachment 8639475 [details] [diff] [review] Fix Seems like a simple change, let's uplift to Aurora.
Attachment #8639475 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Catalin, could you please verify this fix on the latest Nightly build? Thanks.
Flags: needinfo?(catalin.varga)
Reporter | ||
Comment 19•9 years ago
|
||
Verified as fixed: FF 42 Build id: 20150809030213 OS: Mac Os X 10.10.4
Flags: needinfo?(catalin.varga)
You need to log in
before you can comment on or make changes to this bug.
Description
•