Closed Bug 1175887 Opened 9 years ago Closed 9 years ago

Not all string tables are properly converted to .strings files

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: stef, Unassigned)

References

Details

Label for remove action after swiping left history item is not localized in build 22 (and wasn't in earlier builds too IIRC).
It seems that this string is in a separate table called "HistoryPanel". I bet we ignore it because it is not listed in xliff-to-strings.py
I think we miss a whole bunch of other string tables in the builds. Going to turn this bug into a more general bug.
tracking-fxios: --- → +
Summary: [Build 22] Remove label in history panel not localized → Not all string tables are properly converted to .strings files
https://github.com/mozilla/firefox-ios/commit/6e7d3ee3567ad3b3fbcf29e07c267ec48ef54731 This is extremely embarrassing. I have not kept xliff-to-strings up to date with the actual string tables that were introduced. So a number of strings that were recently put in separate strings tables were not included in the builds. I think what I would like to do, as a followup bug, is turn the logic of xliff-to-strings around and not work with a whitelist but instead with a blacklist. Or no list at all. Or add logic to detect new string tables in a better way. (Not sure at this point why there is a list at all)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.