1175902 - Empty screenshot box should be hidden in about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on: Firefox 40.0a2 and Firefox 41.0a1 across all platforms

STR
1.Launch Firefox with clean profile.
2.Navigate to about:addons.
3.Install a theme.
4.Select Appearance from the left menu.
4.Click on “More” link that correspond to a theme.

AR
Unresponsive check box is displayed in theme details tab, but anyway it is useless in this context.

Additional notes:
- This issue is reproducible on Firefox 40.0a2 (2015-06-17/18) and Firefox 41.0a1 (2015-06-17/18) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5
- I am attaching screenshots:
           http://i.imgur.com/bN2Ei11.jpg
           http://i.imgur.com/N81wMQx.jpg

Comment 1

[Tim Nguyen :ntim]

This isn't a checkbox, it's a box used to display the screenshots. Although I agree it is misleading when empty.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: conn-not-secure.svg

My JS skills are too low so I can do this only with CSS. The drawback of this solution is we have no more a 10px gap between the image and the box-shadow.

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8626932 [details]
conn-not-secure.svg

Seems like the wrong patch has been attached here.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug1175902.patch

Yes, sorry. Now the correct patch.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8626981 [details] [diff] [review]
Bug1175902.patch

Review of attachment 8626981 [details] [diff] [review]:
-----------------------------------------------------------------

Let's take it for now. If someone wants to do the JS way later then fine.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cabd735fde27

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cabd735fde27

Comment 8

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 41.0a1 (2015-06-18) under Windows 7 64-bit.
Verified fixed on latest Firefox 42.0a1 (2015-07-09) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac Os X 10.9.5.

I noticed that “None” word is very confusing in this situation http://i.imgur.com/LMNgawn.jpg.
What do you think Tim? Is this word necessary to be displayed for a theme without description?

Comment 9

[Tim Nguyen :ntim]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #8)
> I was able to reproduce this issue on Firefox 41.0a1 (2015-06-18) under
> Windows 7 64-bit.
> Verified fixed on latest Firefox 42.0a1 (2015-07-09) under Windows 7 64-bit,
> Ubuntu 14.04 32-bit and Mac Os X 10.9.5.
> 
> I noticed that “None” word is very confusing in this situation
> http://i.imgur.com/LMNgawn.jpg.
> What do you think Tim? Is this word necessary to be displayed for a theme
> without description?

Feels weird to me too. We should probably remove it. Can you file a new bug please ? Thanks !

Comment 10

[Vasilica Tamas, QA [:vtamas]]

(In reply to Tim Nguyen [:ntim] (away 11-14 July) from comment #9)

> Feels weird to me too. We should probably remove it. Can you file a new bug
> please ? Thanks !

Filed Bug 1182473