1176145 - [EME] Expose CDM version number in MediaKeys.keySystem string

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

To help partners debug CDM version specific bugs, we should expose the CDM version number that's installed by reporting it in the keySystem string.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

A better approach would be to add a "version" field to the MediaKeys object; I think we should discuss this with out partners and propose this to the working group, rather than adding something gecko-specific here.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Going to de-prioritize this pending discussion with partners validating the need for it.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Expose CDM version in keySystem attributes

This means users of EME can associate errors in the CDM with CDM versions.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=427862701d19

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0649b95bad43

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0649b95bad43

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Aurora Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee4ff6a63081

Beta Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fcc8c88ffb3

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8650842 [details] [diff] [review]
Patch: Expose CDM version in keySystem attributes

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Netflix won't be able to tell what version of the Adobe CDM they're using; so they won't be able to correlate errors to CDM versions.
[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests, and a test specifically to cover this case.
[Risks and why]: Low; this just changes the string that is reported on a JS object.
[String/UUID change made/needed]: None.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8650842 [details] [diff] [review]
Patch: Expose CDM version in keySystem attributes

The patch is pretty big but 1) I am happy to see that the try push is clean (Mochi-e10s failures don't block us as 41 is non-e10s by default) and 2) there is an automated test. Let's uplift to Aurora42 and Beta41. This patch should help with diagnostics on Netflix-CDM video playback issues.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm hitting conflicts trying to uplift this to aurora. Can we get a branch specific patch for this?

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Wes Kocher (:KWierso) from comment #10)
> I'm hitting conflicts trying to uplift this to aurora. Can we get a branch
> specific patch for this?

You can get rebased patches from the Try push;

Aurora: https://hg.mozilla.org/try/raw-rev/7e9a3d26553d
Beta: https://hg.mozilla.org/try/raw-rev/5f7d948ebbf3

Thanks!

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28994d94c110

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f8e1375f717