Closed Bug 1176145 Opened 4 years ago Closed 4 years ago

[EME] Expose CDM version number in MediaKeys.keySystem string

Categories

(Core :: Audio/Video, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox38.0.5 --- wontfix
firefox39 --- wontfix
firefox40 --- affected
firefox41 --- fixed
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

To help partners debug CDM version specific bugs, we should expose the CDM version number that's installed by reporting it in the keySystem string.
A better approach would be to add a "version" field to the MediaKeys object; I think we should discuss this with out partners and propose this to the working group, rather than adding something gecko-specific here.
Going to de-prioritize this pending discussion with partners validating the need for it.
Priority: P1 → P2
This means users of EME can associate errors in the CDM with CDM versions.
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #8650842 - Flags: review?(edwin)
https://hg.mozilla.org/mozilla-central/rev/0649b95bad43
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Flags: needinfo?(cpearce)
Comment on attachment 8650842 [details] [diff] [review]
Patch: Expose CDM version in keySystem attributes

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Netflix won't be able to tell what version of the Adobe CDM they're using; so they won't be able to correlate errors to CDM versions.
[Describe test coverage new/current, TreeHerder]: We have lots of EME mochitests, and a test specifically to cover this case.
[Risks and why]: Low; this just changes the string that is reported on a JS object.
[String/UUID change made/needed]: None.
Attachment #8650842 - Flags: approval-mozilla-beta?
Attachment #8650842 - Flags: approval-mozilla-aurora?
Comment on attachment 8650842 [details] [diff] [review]
Patch: Expose CDM version in keySystem attributes

The patch is pretty big but 1) I am happy to see that the try push is clean (Mochi-e10s failures don't block us as 41 is non-e10s by default) and 2) there is an automated test. Let's uplift to Aurora42 and Beta41. This patch should help with diagnostics on Netflix-CDM video playback issues.
Attachment #8650842 - Flags: approval-mozilla-beta?
Attachment #8650842 - Flags: approval-mozilla-beta+
Attachment #8650842 - Flags: approval-mozilla-aurora?
Attachment #8650842 - Flags: approval-mozilla-aurora+
I'm hitting conflicts trying to uplift this to aurora. Can we get a branch specific patch for this?
(In reply to Wes Kocher (:KWierso) from comment #10)
> I'm hitting conflicts trying to uplift this to aurora. Can we get a branch
> specific patch for this?

You can get rebased patches from the Try push;

Aurora: https://hg.mozilla.org/try/raw-rev/7e9a3d26553d
Beta: https://hg.mozilla.org/try/raw-rev/5f7d948ebbf3

Thanks!
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.